-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simd and simcli commands #5998
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5998 +/- ##
==========================================
+ Coverage 55.12% 55.32% +0.20%
==========================================
Files 430 428 -2
Lines 25658 25548 -110
==========================================
- Hits 14143 14134 -9
+ Misses 10539 10441 -98
+ Partials 976 973 -3 |
Thanks for feedback @alessio, addressed the changes |
Would be great to get some input on what pieces of |
We should only be copying over the core bits of testing (replay and testnet are not needed). Furthermore, when copying over, we should be examining how it's currently done (which is kinda messy) and what can be done to improve it. |
Sure @alexanderbez, even I thought replay and testnet are not needed. Will go through thoroughly to see how this can be improved and made with a minimal setup |
@fedekunze updated, would you like me to make these changes on gaia also(grouping commands and export state) |
yes please 👍 thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
@sahith-narahari please either rebase on master or merge maser back to allow us to merge this in. |
@alessio updated to master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R'n'R!
ref: #5951
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)