Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simd and simcli commands #5998

Merged
merged 12 commits into from
Apr 20, 2020
Merged

Conversation

sahith-narahari
Copy link
Contributor

@sahith-narahari sahith-narahari commented Apr 15, 2020

ref: #5951


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

simapp/cmd/simd/testnet.go Outdated Show resolved Hide resolved
simapp/cmd/simcli/main.go Outdated Show resolved Hide resolved
simapp/cmd/simd/genaccounts.go Show resolved Hide resolved
simapp/cmd/simd/replay.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #5998 into master will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5998      +/-   ##
==========================================
+ Coverage   55.12%   55.32%   +0.20%     
==========================================
  Files         430      428       -2     
  Lines       25658    25548     -110     
==========================================
- Hits        14143    14134       -9     
+ Misses      10539    10441      -98     
+ Partials      976      973       -3     

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@sahith-narahari
Copy link
Contributor Author

Thanks for feedback @alessio, addressed the changes

@aaronc aaronc changed the title Add integration tests for cli Add simd and simcli commands Apr 16, 2020
@aaronc
Copy link
Member

aaronc commented Apr 16, 2020

Would be great to get some input on what pieces of gaiad/gaiacli to not include here, if any. I know it was mentioned in the call that there some messy stuff there. Should maybe replay or testnet stuff be excluded? @jackzampolin @alexanderbez @alessio

@alexanderbez
Copy link
Contributor

We should only be copying over the core bits of testing (replay and testnet are not needed). Furthermore, when copying over, we should be examining how it's currently done (which is kinda messy) and what can be done to improve it.

@sahith-narahari
Copy link
Contributor Author

Sure @alexanderbez, even I thought replay and testnet are not needed. Will go through thoroughly to see how this can be improved and made with a minimal setup

simapp/cmd/simcli/main.go Outdated Show resolved Hide resolved
@sahith-narahari sahith-narahari marked this pull request as ready for review April 17, 2020 20:29
simapp/cmd/simcli/main.go Outdated Show resolved Hide resolved
simapp/cmd/simcli/main.go Outdated Show resolved Hide resolved
simapp/cmd/simd/main.go Outdated Show resolved Hide resolved
simapp/cmd/simd/main.go Outdated Show resolved Hide resolved
@sahith-narahari
Copy link
Contributor Author

@fedekunze updated, would you like me to make these changes on gaia also(grouping commands and export state)

@fedekunze
Copy link
Collaborator

would you like me to make these changes on gaia also(grouping commands and export state)

yes please 👍 thanks !

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahith-narahari sahith-narahari mentioned this pull request Apr 18, 2020
11 tasks
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alessio
Copy link
Contributor

alessio commented Apr 20, 2020

@sahith-narahari please either rebase on master or merge maser back to allow us to merge this in.

@sahith-narahari
Copy link
Contributor Author

@alessio updated to master

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R'n'R!

@alessio alessio merged commit 50f81b1 into cosmos:master Apr 20, 2020
@clevinson clevinson added this to the v0.39 milestone May 4, 2020
@sahith-narahari sahith-narahari deleted the sahith/add-cli-tests branch May 15, 2020 12:16
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants