Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/ibc: changelog #5960

Merged
merged 2 commits into from
Apr 8, 2020
Merged

x/ibc: changelog #5960

merged 2 commits into from
Apr 8, 2020

Conversation

fedekunze
Copy link
Collaborator

Description

Add CHANGELOG.md entries for the ibc module and updates to the spec.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added T:Docs Changes and features related to documentation. x/ibc labels Apr 8, 2020
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #5960 into ibc-alpha will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           ibc-alpha    #5960   +/-   ##
==========================================
  Coverage      58.37%   58.37%           
==========================================
  Files            396      396           
  Lines          23510    23510           
==========================================
  Hits           13725    13725           
  Misses          8827     8827           
  Partials         958      958           

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze merged commit 6d6c832 into ibc-alpha Apr 8, 2020
@fedekunze fedekunze deleted the ibc-changelog branch April 8, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants