Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: rename keys dir #5834

Closed
wants to merge 2 commits into from
Closed

crypto: rename keys dir #5834

wants to merge 2 commits into from

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Mar 19, 2020

Description

  • rename keys dir to keybase
  • move keyring to own dir

Signed-off-by: Marko Baricevic marbar3778@yahoo.com


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

- rename keys dir to keybase
- move keyring to own dir

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle self-assigned this Mar 19, 2020
@tac0turtle tac0turtle added C:Crypto C:Keys Keybase, KMS and HSMs labels Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #5834 into master will not change coverage by %.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##           master    #5834   +/-   ##
=======================================
  Coverage   32.30%   32.30%           
=======================================
  Files         353      353           
  Lines       39461    39461           
=======================================
  Hits        12749    12749           
  Misses      25439    25439           
  Partials     1273     1273           

@tac0turtle
Copy link
Member Author

@alessio to move keyring out of keybase i would need to move structs to be public. is this fine? I see that it was purposefully kept like this so not sure if we want it to change

@alessio
Copy link
Contributor

alessio commented Mar 20, 2020

to move keyring out of keybase i would need to move structs to be public.

Which structs @marbar3778 ?

@tac0turtle
Copy link
Member Author

close in favor of #5866

@tac0turtle tac0turtle closed this Mar 24, 2020
@tac0turtle tac0turtle deleted the marko/rename_keys branch March 24, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Crypto C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants