Comment client breaking

[jgimeno]

Closes: #5748

Description

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[alessio]

Input file file.json (provided by @jgimeno):

alessio@bangalter:~/work/gaia$ cat file.json 
{"type":"cosmos-sdk/StdTx","value":{"msg":[{"type":"cosmos-sdk/MsgCreateValidator","value":{"description":{"moniker":"testing"},"commission":{"rate":"0.100000000000000000","max_rate":"0.200000000000000000","max_change_rate":"0.010000000000000000"},"min_self_delegation":"1","delegator_address":"cosmos139ge8zja3cdeqyj9ln4w7864ns2qd32m85cn6r","validator_address":"cosmosvaloper139ge8zja3cdeqyj9ln4w7864ns2qd32mzqvxks","pubkey":"cosmosvalconspub1zcjduepqphuekucs22f5sc48f2truzu5ckvghtj9y4uq2g7gw0funw8gcw8svgzdmt","value":{"denom":"stake","amount":"100000000"}}}],"fee":{"amount":[],"gas":"200000"},"signatures":[{"pub_key":{"type":"tendermint/PubKeySecp256k1","value":"AyD7bZGcZUCvrK3W3kkKouJgBVJlzLaqyK4B8wbjfnRd"},"signature":"RcqEAbVWkzQjU3vVwkIZPzWpCkR8w9h0tMyTa4TivYMXagiC2TpVnY7b4+acLKT9JKLK5SOaU/BIu3vH3cSsOg=="}],"memo":"777460061688fddbaa04fd1b40f850179b45de76@192.168.1.17:26656"}}

Compile gaia from master branch:

alessio@bangalter:~/work/gaia$ make install
go install -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=gaia -X github.com/cosmos/cosmos-sdk/version.ServerName=gaiad -X github.com/cosmos/cosmos-sdk/version.ClientName=gaiacli -X github.com/cosmos/cosmos-sdk/version.Version=0.0.0-159-g680bb19 -X github.com/cosmos/cosmos-sdk/version.Commit=680bb196d6c5ece0c78875dff0175fdd780711ac -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger"' -trimpath ./cmd/gaiad
go install -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=gaia -X github.com/cosmos/cosmos-sdk/version.ServerName=gaiad -X github.com/cosmos/cosmos-sdk/version.ClientName=gaiacli -X github.com/cosmos/cosmos-sdk/version.Version=0.0.0-159-g680bb19 -X github.com/cosmos/cosmos-sdk/version.Commit=680bb196d6c5ece0c78875dff0175fdd780711ac -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger"' -trimpath ./cmd/gaiacli

Verifying gaiacli version output:

alessio@bangalter:~/work/gaia$ gaiacli version --long --output=text
name: gaia
server_name: gaiad
client_name: gaiacli
version: 0.0.0-159-g680bb19
commit: 680bb196d6c5ece0c78875dff0175fdd780711ac
build_tags: netgo,ledger
go: go version go1.14 linux/amd64

Encoding file.json and saving output to output.master

alessio@bangalter:~/work/gaia$ gaiacli tx encode file.json > output.master

Compiling gaia from master HEAD-1 commit:

alessio@bangalter:~/work/gaia$ git checkout 89e8df1882f6af6b939bc6f8a5f244b0cb04619d
Note: switching to '89e8df1882f6af6b939bc6f8a5f244b0cb04619d'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
  git switch -c <new-branch-name>
Or undo this operation with:
  git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 89e8df1 Merge PR #312: proto: remove proto mentions
alessio@bangalter:~/work/gaia$ make install
go install -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=gaia -X github.com/cosmos/cosmos-sdk/version.ServerName=gaiad -X github.com/cosmos/cosmos-sdk/version.ClientName=gaiacli -X github.com/cosmos/cosmos-sdk/version.Version=0.0.0-158-g89e8df1 -X github.com/cosmos/cosmos-sdk/version.Commit=89e8df1882f6af6b939bc6f8a5f244b0cb04619d -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger"' -trimpath ./cmd/gaiad
go install -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=gaia -X github.com/cosmos/cosmos-sdk/version.ServerName=gaiad -X github.com/cosmos/cosmos-sdk/version.ClientName=gaiacli -X github.com/cosmos/cosmos-sdk/version.Version=0.0.0-158-g89e8df1 -X github.com/cosmos/cosmos-sdk/version.Commit=89e8df1882f6af6b939bc6f8a5f244b0cb04619d -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger"' -trimpath ./cmd/gaiacli

Verifying gaia version output:

alessio@bangalter:~/work/gaia$ gaiacli version --long --output=text
name: gaia
server_name: gaiad
client_name: gaiacli
version: 0.0.0-158-g89e8df1
commit: 89e8df1882f6af6b939bc6f8a5f244b0cb04619d
build_tags: netgo,ledger
go: go version go1.14 linux/amd64

Encoding file.json and saving output to output.89e8df1882f6af6b939bc6f8a5f244b0cb04619d:

alessio@bangalter:~/work/gaia$ gaiacli tx encode file.json > output.89e8df1882f6af6b939bc6f8a5f244b0cb04619d

Compare outputs:

alessio@bangalter:~/work/gaia$ diff -u output.master output.89e8df1882f6af6b939bc6f8a5f244b0cb04619d 
--- output.master	2020-03-17 00:34:34.518007264 +0100
+++ output.89e8df1882f6af6b939bc6f8a5f244b0cb04619d	2020-03-17 00:35:06.387062741 +0100
@@ -1 +1 @@
-"KCgWqQrkAes2HQEKCQoHdGVzdGluZxI7ChIxMDAwMDAwMDAwMDAwMDAwMDASEjIwMDAwMDAwMDAwMDAwMDAwMBoRMTAwMDAwMDAwMDAwMDAwMDAaATEiFIlRk4pdjhuQEkX86u8fVZwUBsVbKhSJUZOKXY4bkBJF/OrvH1WcFAbFWzJTY29zbW9zdmFsY29uc3B1YjF6Y2pkdWVwcXBodWVrdWNzMjJmNXNjNDhmMnRydXp1NWNrdmdodGo5eTR1cTJnN2d3MGZ1bnc4Z2N3OHN2Z3pkbXQ6EgoFc3Rha2USCTEwMDAwMDAwMBIEEMCaDBpqCibrWumHIQMg+22RnGVAr6yt1t5JCqLiYAVSZcy2qsiuAfMG4350XRJARcqEAbVWkzQjU3vVwkIZPzWpCkR8w9h0tMyTa4TivYMXagiC2TpVnY7b4+acLKT9JKLK5SOaU/BIu3vH3cSsOiI7Nzc3NDYwMDYxNjg4ZmRkYmFhMDRmZDFiNDBmODUwMTc5YjQ1ZGU3NkAxOTIuMTY4LjEuMTc6MjY2NTY="
+"mgMoKBapCuQB6zYdAQoJCgd0ZXN0aW5nEjsKEjEwMDAwMDAwMDAwMDAwMDAwMBISMjAwMDAwMDAwMDAwMDAwMDAwGhExMDAwMDAwMDAwMDAwMDAwMBoBMSIUiVGTil2OG5ASRfzq7x9VnBQGxVsqFIlRk4pdjhuQEkX86u8fVZwUBsVbMlNjb3Ntb3N2YWxjb25zcHViMXpjamR1ZXBxcGh1ZWt1Y3MyMmY1c2M0OGYydHJ1enU1Y2t2Z2h0ajl5NHVxMmc3Z3cwZnVudzhnY3c4c3ZnemRtdDoSCgVzdGFrZRIJMTAwMDAwMDAwEgQQwJoMGmoKJuta6YchAyD7bZGcZUCvrK3W3kkKouJgBVJlzLaqyK4B8wbjfnRdEkBFyoQBtVaTNCNTe9XCQhk/NakKRHzD2HS0zJNrhOK9gxdqCILZOlWdjtvj5pwspP0kosrlI5pT8Ei7e8fdxKw6Ijs3Nzc0NjAwNjE2ODhmZGRiYWEwNGZkMWI0MGY4NTAxNzliNDVkZTc2QDE5Mi4xNjguMS4xNzoyNjY1Ng=="

[alexanderbez]

@jgimeno can we instead state which commands break here. AFAIK, it's only tx encode/decode.

[alessio]

This is a bit concerning: cosmos/gaia@680bb19#diff-ef04ec516e080b802253864b259addb3L621

Because of the changes in coins serialization, I'd advise to warn the users about the impact of the change instead of mentioning every single affected command (which could potentially be many)

EDIT: nevermind, that's a different thing (#5790)

[alessio]

Plus, @jgimeno I'd advise to revert the changes in keys serialization. That risks to be a very painful issue for the users

[alexanderbez]

Errr what you linked @alessio has nothing to do with serialization. That's a completely orthogonal change and has been stated in the CHANGELOG already.

[jgimeno]

#5799

[jgimeno]

#5814 we add the comment here.