-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove internal folder in package Crisis #5745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name in x/crisis/types/types.proto
needs to be updated and the proto gen needs to be executed. Otherwise, LGTM :)
…mos/cosmos-sdk into jonathan/5646-remove-internal-crisis
Codecov Report
@@ Coverage Diff @@
## master #5745 +/- ##
==========================================
+ Coverage 36.8% 36.81% +0.01%
==========================================
Files 336 336
Lines 32743 32751 +8
==========================================
+ Hits 12051 12058 +7
- Misses 19464 19465 +1
Partials 1228 1228
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Closes: #5646
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)