Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal folder in package Crisis #5745

Merged
merged 5 commits into from
Mar 3, 2020

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Mar 3, 2020

Closes: #5646

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name in x/crisis/types/types.proto needs to be updated and the proto gen needs to be executed. Otherwise, LGTM :)

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 3, 2020
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #5745 into master will increase coverage by 0.01%.
The diff coverage is 19.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5745      +/-   ##
==========================================
+ Coverage    36.8%   36.81%   +0.01%     
==========================================
  Files         336      336              
  Lines       32743    32751       +8     
==========================================
+ Hits        12051    12058       +7     
- Misses      19464    19465       +1     
  Partials     1228     1228
Impacted Files Coverage Δ
simapp/test_helpers.go 0% <0%> (ø) ⬆️
types/handler.go 77.77% <100%> (+77.77%) ⬆️

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 274f389 into master Mar 3, 2020
@alexanderbez alexanderbez deleted the jonathan/5646-remove-internal-crisis branch March 3, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/crisis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Internal from Module Spec + Update Modules
3 participants