-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate slashing module to use new Simapp #5744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One thing I want to be very cautious of is that the helpers and aux methods and functions found in simapp/test_helpers.go
don't become tech debt. After we've updated all the modules, we should go back through these and make sure every method and function makes sense, keeping it DRY and maintainable.
Codecov Report
@@ Coverage Diff @@
## master #5744 +/- ##
==========================================
+ Coverage 36.79% 36.81% +0.02%
==========================================
Files 336 336
Lines 32752 32751 -1
==========================================
+ Hits 12051 12058 +7
+ Misses 19473 19465 -8
Partials 1228 1228
|
Closes: #4875
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)