Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase types/module coverage up to 80% #5740

Merged
merged 3 commits into from
Mar 3, 2020
Merged

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 3, 2020

Add interface tests.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio added T: Tests R4R A:automerge Automatically merge PR once all prerequisites pass. labels Mar 3, 2020
@alessio alessio requested a review from tac0turtle March 3, 2020 13:28
@alessio alessio requested a review from jgimeno March 3, 2020 13:28
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@mergify mergify bot merged commit 3349c97 into master Mar 3, 2020
@mergify mergify bot deleted the alessio/types-testcases branch March 3, 2020 13:38
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #5740 into master will increase coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5740      +/-   ##
=========================================
+ Coverage   36.52%   36.8%   +0.28%     
=========================================
  Files         336     336              
  Lines       32743   32743              
=========================================
+ Hits        11958   12051      +93     
+ Misses      19556   19464      -92     
+ Partials     1229    1228       -1
Impacted Files Coverage Δ
crypto/keys/keyring.go 52.08% <0%> (ø) ⬆️
types/module/module.go 100% <0%> (+89.42%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants