Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage across the store package #5727

Merged
merged 6 commits into from
Feb 28, 2020
Merged

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 28, 2020

Run make mocks to ensure reproducibility.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Run make mocks to ensure reproducibility.
store/types/pruning_test.go Show resolved Hide resolved
store/types/pruning_test.go Show resolved Hide resolved
store/types/pruning_test.go Show resolved Hide resolved
@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 28, 2020
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #5727 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5727      +/-   ##
==========================================
+ Coverage   35.77%   35.79%   +0.01%     
==========================================
  Files         335      336       +1     
  Lines       32719    32727       +8     
==========================================
+ Hits        11706    11714       +8     
  Misses      19783    19783              
  Partials     1230     1230
Impacted Files Coverage Δ
server/pruning.go 100% <100%> (ø)

@alessio alessio merged commit 5f14dc2 into master Feb 28, 2020
@alessio alessio deleted the alessio/increase-coverage branch February 28, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants