Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove x/mock #5642

Merged
merged 8 commits into from
Feb 14, 2020
Merged

Remove x/mock #5642

merged 8 commits into from
Feb 14, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 14, 2020

Description

Remove x/mock in favor of SimApp. Each module should also be careful to have its unit tests be contained under the package {module}_test to avoid import cycles and dependency hell.

Note, there still exist modules where the keeper (integration/unit) tests still create ad-hoc applications. These need to be refactored in order to:

  1. Have package renamed (to {module}_test)
  2. Use simapp

ref: #4875


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

x/slashing/app_test.go Show resolved Hide resolved
x/gov/common_test.go Outdated Show resolved Hide resolved
x/gov/common_test.go Outdated Show resolved Hide resolved
x/gov/common_test.go Outdated Show resolved Hide resolved
x/gov/common_test.go Outdated Show resolved Hide resolved
x/staking/common_test.go Outdated Show resolved Hide resolved
x/staking/common_test.go Outdated Show resolved Hide resolved
x/gov/common_test.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez marked this pull request as ready for review February 14, 2020 15:05
@alexanderbez alexanderbez merged commit 05c21a5 into master Feb 14, 2020
@alexanderbez alexanderbez deleted the bez/remove-mock branch February 14, 2020 15:30
@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #5642 into master will not change coverage.
The diff coverage is 14.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5642   +/-   ##
=======================================
  Coverage   40.49%   40.49%           
=======================================
  Files         323      323           
  Lines       27134    27134           
=======================================
  Hits        10987    10987           
  Misses      15085    15085           
  Partials     1062     1062
Impacted Files Coverage Δ
x/auth/client/query.go 0% <0%> (ø) ⬆️
x/gov/client/utils/query.go 24.36% <20%> (ø) ⬆️

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants