-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove x/mock #5642
Merged
Merged
Remove x/mock #5642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Feb 14, 2020
golangcibot
reviewed
Feb 14, 2020
alexanderbez
requested review from
alessio,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
February 14, 2020 15:05
tac0turtle
approved these changes
Feb 14, 2020
jackzampolin
approved these changes
Feb 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #5642 +/- ##
=======================================
Coverage 40.49% 40.49%
=======================================
Files 323 323
Lines 27134 27134
=======================================
Hits 10987 10987
Misses 15085 15085
Partials 1062 1062
|
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
x/mock
in favor ofSimApp
. Each module should also be careful to have its unit tests be contained under the package{module}_test
to avoid import cycles and dependency hell.Note, there still exist modules where the keeper (integration/unit) tests still create ad-hoc applications. These need to be refactored in order to:
{module}_test
)ref: #4875
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)