ICS07 follow up changes #5606
Merged
ICS07 follow up changes #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested changes
Feb 3, 2020
jackzampolin
reviewed
Feb 3, 2020
jackzampolin
reviewed
Feb 3, 2020
jackzampolin
reviewed
Feb 3, 2020
jackzampolin
reviewed
Feb 3, 2020
jackzampolin
reviewed
Feb 3, 2020
| @@ -21,18 +23,52 @@ var _ clientexported.ClientState = ClientState{} | |||
| type ClientState struct { | |||
| // Client ID | |||
| ID string `json:"id" yaml:"id"` | |||
| // Duration of the period since the LastestTimestamp during which the | |||
| // submitted headers are valid for upgrade | |||
| TrustingPeriod time.Duration `json:"trusting_period" yaml:"trusting_period"` | |||
There was a problem hiding this comment.
Do we need both trusting and unbonding? Can't we default trusting to a fraction of the unbonding period?
jackzampolin
reviewed
Feb 3, 2020
jackzampolin
reviewed
Feb 3, 2020
AdityaSripal
previously requested changes
Feb 12, 2020
x/ibc/02-client/keeper/keeper.go
Outdated
| ) (exported.ClientState, error) { | ||
| var clientState exported.ClientState | ||
| height := uint64(ctx.BlockHeight()) |
There was a problem hiding this comment.
Should not be using our own chain's BlockHeight here. Should be using the other chain's height.
Fixed this on my branch by adding Height field and GetHeight method to ConsensusState
…dekunze/ics07-follow-ups
* refactor tendermint package to move msgs here * fix rest of package to accomadate 07 refactor * added GetHeight to ConsensusState and moved clientstate struct creation to 07-tendermint * start work on making misbehavior retrieve consensusState LTE misbehavior * allow misbehavior submission at height not equal to persisted consensusState * optimize submitMisbehavior by erroring earlier * cleanup misbehavior and propose lazy fix * fix bug * Update x/ibc/02-client/keeper/client.go Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * address fede review * add chain-id into clientstate * address necessary fede review Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
… fedekunze/ics07-follow-ups
golangcibot
reviewed
Feb 18, 2020
| } | ||
|
|
||
| func (suite *KeeperTestSuite) SetupTest() { | ||
| testHeight = 1 |
There was a problem hiding this comment.
unnecessary conversion (from unconvert)
| } | ||
|
|
||
| func (suite *KeeperTestSuite) SetupTest() { | ||
| isCheckTx := false | ||
| suite.now = time.Date(2020, 1, 2, 0, 0, 0, 0, time.UTC) | ||
| now2 := suite.now.Add(time.Duration(time.Hour * 1)) |
There was a problem hiding this comment.
unnecessary conversion (from unconvert)
golangcibot
reviewed
Feb 18, 2020
| isCheckTx := false | ||
| app := simapp.Setup(isCheckTx) | ||
| suite.now = time.Date(2020, 1, 2, 0, 0, 0, 0, time.UTC) | ||
| now2 := suite.now.Add(time.Duration(time.Hour * 1)) |
There was a problem hiding this comment.
unnecessary conversion (from unconvert)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses comments from #5485 (review)
Implements changes from cosmos/ibc#367
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)