Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swagger.yaml #5605

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Update swagger.yaml #5605

merged 1 commit into from
Feb 3, 2020

Conversation

mircea-c
Copy link

@mircea-c mircea-c commented Feb 3, 2020

Updated host name to with new URL

Closes: #XXX

Description

Updated swagger config. Changed the host name to the new hub node URL.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Updated host name to with new URL
@@ -40,7 +40,7 @@ paths:
description: Information about the connected node
summary: The properties of the connected node
tags:
- Tendermint RPC
- Gaia REST
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just the tag under which the endpoints are grouped

Suggested change
- Gaia REST
- Tendermint RPC

@alexanderbez alexanderbez merged commit 43137ee into master Feb 3, 2020
@alexanderbez alexanderbez deleted the mircea/update-swagger branch February 3, 2020 14:28
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #5605 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5605      +/-   ##
==========================================
- Coverage   53.42%   53.41%   -0.02%     
==========================================
  Files         322      322              
  Lines       19745    19745              
==========================================
- Hits        10549    10547       -2     
- Misses       8379     8381       +2     
  Partials      817      817
Impacted Files Coverage Δ
x/mock/app.go 65.24% <0%> (-1.22%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants