Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Proto Linting #5591

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Fix Proto Linting #5591

merged 1 commit into from
Jan 30, 2020

Conversation

alexanderbez
Copy link
Contributor


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez marked this pull request as ready for review January 30, 2020 15:15
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ci is taking FOREVER

@alexanderbez
Copy link
Contributor Author

this ci is taking FOREVER

Blame amino + other misc. performance oddities

@alexanderbez alexanderbez merged commit b669ac5 into master Jan 30, 2020
@alexanderbez alexanderbez deleted the bez/proto-lint branch January 30, 2020 16:26
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #5591 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5591      +/-   ##
==========================================
- Coverage   53.28%   53.27%   -0.02%     
==========================================
  Files         319      319              
  Lines       19588    19588              
==========================================
- Hits        10438    10436       -2     
- Misses       8330     8332       +2     
  Partials      820      820
Impacted Files Coverage Δ
x/mock/app.go 62.83% <0%> (-1.36%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants