Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyring error message on macos #5501

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Fix keyring error message on macos #5501

merged 3 commits into from
Jan 9, 2020

Conversation

jackzampolin
Copy link
Member

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

go.mod Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #5501 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5501      +/-   ##
==========================================
+ Coverage    54.5%   54.51%   +0.01%     
==========================================
  Files         313      313              
  Lines       18880    18880              
==========================================
+ Hits        10291    10293       +2     
+ Misses       7805     7803       -2     
  Partials      784      784
Impacted Files Coverage Δ
x/mock/app.go 64.18% <0%> (+1.35%) ⬆️

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit d7bdfe3 into master Jan 9, 2020
@alexanderbez alexanderbez deleted the jack/keyring-error branch January 9, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants