Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Error Handling #5421

Merged
merged 32 commits into from
Dec 27, 2019
Merged

Refactor Error Handling #5421

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
b291d5c
Remove old errors and start updating /types
alexanderbez Dec 17, 2019
5d2b333
Update types
alexanderbez Dec 18, 2019
48c18e8
Update BaseApp's runTx and runMsgs
alexanderbez Dec 18, 2019
d983b45
Fix check against runTxModeDeliver
alexanderbez Dec 18, 2019
264260a
Fix checks in runMsgs
alexanderbez Dec 18, 2019
cd3095c
Fix error message
alexanderbez Dec 18, 2019
84c16e2
Update helpers
alexanderbez Dec 18, 2019
c7a3513
Update ABCI methods
alexanderbez Dec 18, 2019
87badbe
Implement and use QueryResult
alexanderbez Dec 18, 2019
9967eca
Update store package
alexanderbez Dec 18, 2019
fd28b66
Fix runTx by using named returns to handle defer calls correctly
alexanderbez Dec 18, 2019
7ecb8df
Update baseapp tests
alexanderbez Dec 18, 2019
4c9525a
Fix result nil call
alexanderbez Dec 18, 2019
a1c1439
Remove old error types and logic
alexanderbez Dec 18, 2019
5afcd58
Merge branch 'master' into bez/4844-handler-error-refactor
alexanderbez Dec 18, 2019
16a6f0b
Add changelog entry
alexanderbez Dec 18, 2019
ca3526e
Merge branch 'bez/4844-handler-error-refactor' of github.com:cosmos/c…
alexanderbez Dec 18, 2019
8ab61b3
Update baseapp/abci.go
alexanderbez Dec 18, 2019
406e634
Fix handleQueryP2P call
alexanderbez Dec 18, 2019
4934c3a
Add godoc for QueryResult
alexanderbez Dec 18, 2019
126edf5
Merge branch 'master' into bez/4844-handler-error-refactor
alexanderbez Dec 18, 2019
6bee805
Remove redundant gInfo setting
alexanderbez Dec 19, 2019
26ccbc3
Cleanup flow in DeliverTx and CheckTx
alexanderbez Dec 23, 2019
bad58af
Remove success from ABCIMessageLog
alexanderbez Dec 23, 2019
43c4167
Update runMsgs semantics to return error upon first failure
alexanderbez Dec 23, 2019
4609d0e
Update godocs in BaseApp
alexanderbez Dec 23, 2019
da356f0
Merge branch 'master' into bez/4844-handler-error-refactor
alexanderbez Dec 23, 2019
c65d59c
Update godoc
alexanderbez Dec 23, 2019
76fbe0b
Update docs
alexanderbez Dec 24, 2019
ff229ac
Update docs
alexanderbez Dec 24, 2019
ec36e87
Merge branch 'master' into bez/4844-handler-error-refactor
alexanderbez Dec 27, 2019
e64d87f
Merge PR #5429: Refactor Error Handling - II (Modules)
alexanderbez Dec 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove redundant gInfo setting
  • Loading branch information
@alexanderbez
alexanderbez committed Dec 19, 2019
commit 6bee8053ef511b3805b4cf617326e084b1b82151
2 changes: 0 additions & 2 deletions baseapp/baseapp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,6 @@ func (app *BaseApp) runTx(mode runTxMode, txBytes []byte, tx sdk.Tx) (gInfo sdk.
gasWanted = ctx.GasMeter().Limit()

if err != nil {
gInfo = sdk.GasInfo{GasWanted: gasWanted, GasUsed: ctx.GasMeter().GasConsumed()}
return gInfo, nil, err
alexanderbez marked this conversation as resolved.
Show resolved Hide resolved
}

Expand All @@ -629,7 +628,6 @@ func (app *BaseApp) runTx(mode runTxMode, txBytes []byte, tx sdk.Tx) (gInfo sdk.
msCache.Write()
}

gInfo = sdk.GasInfo{GasWanted: gasWanted, GasUsed: runMsgCtx.GasMeter().GasConsumed()}
return gInfo, result, err
}

Expand Down