Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scaffolding tooling to README #5376

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Add Scaffolding tooling to README #5376

merged 2 commits into from
Dec 9, 2019

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Dec 9, 2019 •
edited by fedekunze
Loading

  • added scaffolding tool to readme
  • remvoed unessecary docs

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@tac0turtle
Add Scaffolding tooling to README
43358b7 
- added scaffolding tool to readme
- remvoed unessecary docs

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle added the T:Docs Changes and features related to documentation. label Dec 9, 2019
@tac0turtle tac0turtle self-assigned this Dec 9, 2019
@fedekunze fedekunze added the R4R label Dec 9, 2019
@fedekunze fedekunze merged commit 7d7821b into master Dec 9, 2019
@fedekunze fedekunze deleted the marko/add_scaffolding_README branch December 9, 2019 11:32
xiangjianmeng pushed a commit to xiangjianmeng/cosmos-sdk that referenced this pull request Dec 18, 2019
@tac0turtle @xiangjianmeng
Add Scaffolding tooling to README (cosmos#5376)
15431ef 
- added scaffolding tool to README
- removed unnecessary docs

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees

@tac0turtle tac0turtle

Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tac0turtle @fedekunze