Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Sortable Decimal Bytes #5360

Merged
merged 10 commits into from
Dec 5, 2019
Merged

R4R: Sortable Decimal Bytes #5360

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b13cace
SortableDecBytes
sunnya97 Dec 3, 2019
7b3f4dc
typos
sunnya97 Dec 3, 2019
aa97189
Apply suggestions from code review
sunnya97 Dec 3, 2019
5cf673b
removed extra comments
sunnya97 Dec 3, 2019
eed5510
Apply suggestions from code review
alexanderbez Dec 4, 2019
095b2cd
Merge branch 'master' into sunny/sortabledecbytes
alexanderbez Dec 4, 2019
36f0dbd
Merge branch 'master' into sunny/sortabledecbytes
fedekunze Dec 4, 2019
2c757d9
address @karzak review
sunnya97 Dec 4, 2019
3a65426
Merge branch 'sunny/sortabledecbytes' of https://github.com/cosmos/co…
sunnya97 Dec 4, 2019
0c8eb18
Merge branch 'master' into sunny/sortabledecbytes
alexanderbez Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed extra comments
  • Loading branch information
@sunnya97
sunnya97 committed Dec 3, 2019
commit 5cf673b97a527faea289f3ed39541db1b03d6b2b
3 changes: 0 additions & 3 deletions types/decimal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,9 +558,6 @@ func ValidSortableDec(dec Dec) bool {
return dec.LTE(OneDec().Quo(SmallestDec()))
}

// FormattingStringSortableBytes is the string used in Sprintf to left and right pad the sdk.Dec
// It adjusts based on the Precision constant

// Returns a byte slice representation of an sdk.Dec that can be sorted.
alexanderbez marked this conversation as resolved.
Show resolved Hide resolved
// Left and right pads with 0s so there are 18 digits to left and right of decimal point
alexanderbez marked this conversation as resolved.
Show resolved Hide resolved
// For this reason, there is a maximum and minimum value for this, enforced by ValidSortableDec
alexanderbez marked this conversation as resolved.
Show resolved Hide resolved
Expand Down