Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Testing #5103

Merged
merged 10 commits into from
Sep 26, 2019
Merged

Migration Testing #5103

merged 10 commits into from
Sep 26, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 25, 2019

  • Add TODO to return error in migration command instead of panic
  • Fix version in x/staking (v0.37 to v0.38)
  • Update v0.38 migration to include staking

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

x/genutil/types/types.go Show resolved Hide resolved
x/genutil/client/cli/migrate.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #5103 into master will increase coverage by 0.05%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #5103      +/-   ##
==========================================
+ Coverage    54.8%   54.85%   +0.05%     
==========================================
  Files         294      295       +1     
  Lines       18222    18261      +39     
==========================================
+ Hits         9986    10017      +31     
- Misses       7490     7495       +5     
- Partials      746      749       +3

@alexanderbez alexanderbez merged commit fbdf0e7 into master Sep 26, 2019
@alexanderbez alexanderbez deleted the bez/migration-testing branch September 26, 2019 16:07
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants