Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/nft Ownership #5071

Merged
merged 6 commits into from
Sep 22, 2019
Merged

x/nft Ownership #5071

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
549f95b
Update .github/CODEOWNERS
alexanderbez Sep 19, 2019
837b83b
Add boilerplate for nft contract
alexanderbez Sep 19, 2019
05f5ca2
Update nft contract
alexanderbez Sep 19, 2019
e80245a
Update nft contract
alexanderbez Sep 19, 2019
e4ce228
Merge branch 'master' into bez/nft-ownership
alexanderbez Sep 20, 2019
4e56800
Merge branch 'master' into bez/nft-ownership
alexanderbez Sep 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,12 @@

# Primary repo maintainers
* @rigelrozanski @alexanderbez @jackzampolin @alessio @fedekunze

###############################################################################
# Module Specific Ownership
# See CONTRIBUTING.md for further details
###############################################################################

# The following contributors own all files in the x/nft directory at the root
# of the repository and any of its subdirectories.
x/nft @okwme @fedekunze
Copy link
Contributor Author

@alexanderbez alexanderbez Sep 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedekunze @okwme if there are other contributors you'd like to add, please add them here.

18 changes: 18 additions & 0 deletions x/nft/CONTRACT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Contract

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedekunze @okwme @rigelrozanski Would like input here on what we would typically expect and/or want in a soft contract for module ownership and maintenance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Review issues and pull requests related to the module
  • Resolve issues and pull requests within 90 days
  • Ensure module is ready for SDK releases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated :)

This document outlines the "soft contract" expected by the `CODEOWNERS` and maintainers
of the `x/nft` module to follow and uphold. The agreed-upon members are expected
to abide by the following:

- Review and provide feedback on PRs that primarily impact or modify the `x/nft`
module within 30 days.
- Review and provide feedback on issues related to the `x/nft` module within 30
days.
- Maintain compatibility with the APIs, design philosophy, architecture and the
broader set of tools (e.g. simulation) within the SDK.

If the broader set of `CODEOWNERS` and maintainers of the SDK deem that the stated
contract has been breached by a containing member of the `x/nft` module, that
member may be removed with or without warning from the `CODEOWNERS`. If the entire
set of owners and maintainers are deemed to break the contract, the `x/nft` module
maybe removed with or without warning from the SDK.