Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Prealloc, Gosec, Golint linters #5055

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Added Prealloc, Gosec, Golint linters #5055

merged 2 commits into from
Sep 17, 2019

Conversation

tac0turtle
Copy link
Member

  • added prealloc, golint, gosec

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@tac0turtle
Add more linters
d1108bc 
- added prealloc, golint, gosec

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle added R4R Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Sep 17, 2019
@tac0turtle tac0turtle self-assigned this Sep 17, 2019
@tac0turtle tac0turtle changed the title Add more linters Added Prealloc, Gosec, Golint linters Sep 17, 2019
@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #5055 into master will decrease coverage by 0.04%.
The diff coverage is 76.47%.

@@            Coverage Diff            @@
##           master   #5055      +/-   ##
=========================================
- Coverage   55.05%     55%   -0.05%     
=========================================
  Files         291     291              
  Lines       17837   17813      -24     
=========================================
- Hits         9820    9798      -22     
+ Misses       7310    7308       -2     
  Partials      707     707

alexanderbez
alexanderbez approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like mainly slice capacity adjustments. ACK.

@alexanderbez alexanderbez merged commit 936cffe into master Sep 17, 2019
@alexanderbez alexanderbez deleted the marko/mooore_linters branch September 17, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@fedekunze fedekunze Awaiting requested review from fedekunze

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees

@tac0turtle tac0turtle

Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tac0turtle @alexanderbez