Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linters and add golint #5048

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Fix linters and add golint #5048

merged 3 commits into from
Sep 16, 2019

Conversation

tac0turtle
Copy link
Member

  • fixed some outstanding linters and added golint

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

- fixed some outstanding linters and added golint

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Sep 16, 2019
@tac0turtle tac0turtle self-assigned this Sep 16, 2019
@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #5048 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #5048      +/-   ##
=========================================
- Coverage   55.01%     55%   -0.01%     
=========================================
  Files         291     291              
  Lines       17819   17815       -4     
=========================================
- Hits         9803    9800       -3     
+ Misses       7309    7308       -1     
  Partials      707     707

@tnachen
Copy link
Contributor

tnachen commented Sep 16, 2019

This looks great to add!

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@alexanderbez alexanderbez merged commit 6684cdf into master Sep 16, 2019
@alexanderbez alexanderbez deleted the marko/golint branch September 16, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants