start individual decorator tests

baseapp/baseapp_test.go

@@ -987,7 +987,6 @@ func TestTxGasLimits(t *testing.T) {
 		bapp.SetAnteHandler(func(ctx sdk.Context, tx sdk.Tx, simulate bool) (newCtx sdk.Context, err error) {
 			newCtx = ctx.WithGasMeter(sdk.NewGasMeter(gasGranted))
 
-			// Decorator will catch an OutOfGasPanic caused in the next antehandler
 			// AnteHandlers must have their own defer/recover in order for the BaseApp
 			// to know how much gas was used! This is because the GasMeter is created in
 			// the AnteHandler, but if it panics the context won't be set properly in

x/auth/ante/basic_test.go

@@ -0,0 +1,101 @@
+package ante_test
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+	"github.com/tendermint/tendermint/crypto"
+
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/cosmos/cosmos-sdk/x/auth/ante"
+	"github.com/cosmos/cosmos-sdk/x/auth/types"
+)
+
+func TestValidateBasic(t *testing.T) {
+	// setup
+	_, ctx := createTestApp(true)
+
+	// keys and addresses
+	priv1, _, addr1 := types.KeyTestPubAddr()
+
+	// msg and signatures
+	msg1 := types.NewTestMsg(addr1)
+	fee := types.NewTestStdFee()
+
+	msgs := []sdk.Msg{msg1}
+
+	privs, accNums, seqs := []crypto.PrivKey{}, []uint64{}, []uint64{}
+	invalidTx := types.NewTestTx(ctx, msgs, privs, accNums, seqs, fee)
+
+	vbd := ante.NewValidateBasicDecorator()
+	antehandler := sdk.ChainDecorators(vbd)
+	_, err := antehandler(ctx, invalidTx, false)
+
+	require.NotNil(t, err, "Did not error on invalid tx")
+
+	privs, accNums, seqs = []crypto.PrivKey{priv1}, []uint64{0}, []uint64{0}
+	validTx := types.NewTestTx(ctx, msgs, privs, accNums, seqs, fee)
+
+	_, err = antehandler(ctx, validTx, false)
+	require.Nil(t, err, "ValidateBasicDecorator returned error on valid tx. err: %v", err)
+}
+
+func TestValidateMemo(t *testing.T) {
+	// setup
+	app, ctx := createTestApp(true)
+
+	// keys and addresses
+	priv1, _, addr1 := types.KeyTestPubAddr()
+
+	// msg and signatures
+	msg1 := types.NewTestMsg(addr1)
+	fee := types.NewTestStdFee()
+
+	msgs := []sdk.Msg{msg1}
+
+	privs, accNums, seqs := []crypto.PrivKey{priv1}, []uint64{0}, []uint64{0}
+	invalidTx := types.NewTestTxWithMemo(ctx, msgs, privs, accNums, seqs, fee, strings.Repeat("01234567890", 500))
+
+	vmd := ante.NewValidateMemoDecorator(app.AccountKeeper)
+	antehandler := sdk.ChainDecorators(vmd)
+	_, err := antehandler(ctx, invalidTx, false)
+
+	require.NotNil(t, err, "Did not error on tx with high memo")
+
+	validTx := types.NewTestTxWithMemo(ctx, msgs, privs, accNums, seqs, fee, strings.Repeat("01234567890", 10))
+
+	_, err = antehandler(ctx, validTx, false)
+	require.Nil(t, err, "ValidateBasicDecorator returned error on valid tx. err: %v", err)
+
+}
+
+func TestConsumeGasForTxSize(t *testing.T) {
+	// setup
+	app, ctx := createTestApp(true)
+
+	cgtsd := ante.NewConsumeGasForTxSizeDecorator(app.AccountKeeper)
+	antehandler := sdk.ChainDecorators(cgtsd)
+
+	params := app.AccountKeeper.GetParams(ctx)
+	txBytes := []byte(strings.Repeat("a", 10))
+	expectedGas := sdk.Gas(len(txBytes)) * params.TxSizeCostPerByte
+
+	// Set ctx with TxBytes manually
+	ctx = ctx.WithTxBytes(txBytes)
+
+	// track how much gas is necessary to retrieve parameters
+	//
+	beforeGas := ctx.GasMeter().GasConsumed()
+	app.AccountKeeper.GetParams(ctx)
+	afterGas := ctx.GasMeter().GasConsumed()
+	expectedGas += afterGas - beforeGas
+
+	// No need to send tx here since this Decorator will do nothing with it
+	beforeGas = ctx.GasMeter().GasConsumed()
+	ctx, err := antehandler(ctx, nil, false)
+	require.Nil(t, err, "ConsumeGasForTxSizeDecorator returned error: %v", err)
+
+	consumedGas := ctx.GasMeter().GasConsumed() - beforeGas
+	require.Equal(t, sdk.Gas(expectedGas), consumedGas, "Decorator did not consume the correct amount of gas")
+}

x/auth/ante/fee_test.go

@@ -0,0 +1,97 @@
+package ante_test
+
+import (
+	"testing"
+
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/cosmos/cosmos-sdk/x/auth/ante"
+	"github.com/cosmos/cosmos-sdk/x/auth/types"
+	"github.com/stretchr/testify/require"
+	"github.com/tendermint/tendermint/crypto"
+)
+
+func TestEnsureMempoolFees(t *testing.T) {
+	// setup
+	_, ctx := createTestApp(true)
+
+	mfd := ante.NewMempoolFeeDecorator()
+	antehandler := sdk.ChainDecorators(mfd)
+
+	// keys and addresses
+	priv1, _, addr1 := types.KeyTestPubAddr()
+
+	// msg and signatures
+	msg1 := types.NewTestMsg(addr1)
+	fee := types.NewTestStdFee()
+
+	msgs := []sdk.Msg{msg1}
+
+	privs, accNums, seqs := []crypto.PrivKey{priv1}, []uint64{0}, []uint64{0}
+	tx := types.NewTestTx(ctx, msgs, privs, accNums, seqs, fee)
+
+	// Set high gas price so standard test fee fails
+	atomPrice := sdk.NewDecCoinFromDec("atom", sdk.NewDec(200).Quo(sdk.NewDec(100000)))
+	highGasPrice := []sdk.DecCoin{atomPrice}
+	ctx = ctx.WithMinGasPrices(highGasPrice)
+
+	// Set IsCheckTx to true
+	ctx = ctx.WithIsCheckTx(true)
+
+	// antehandler errors with insufficient fees
+	_, err := antehandler(ctx, tx, false)
+	require.NotNil(t, err, "Decorator should have errored on too low fee for local gasPrice")
+
+	// Set IsCheckTx to false
+	ctx = ctx.WithIsCheckTx(false)
+
+	// antehandler should not error since we do not check minGasPrice in DeliverTx
+	_, err = antehandler(ctx, tx, false)
+	require.Nil(t, err, "MempoolFeeDecorator returned error in DeliverTx")
+
+	// Set IsCheckTx back to true for testing sufficient mempool fee
+	ctx = ctx.WithIsCheckTx(true)
+
+	atomPrice = sdk.NewDecCoinFromDec("atom", sdk.NewDec(0).Quo(sdk.NewDec(100000)))
+	lowGasPrice := []sdk.DecCoin{atomPrice}
+	ctx = ctx.WithMinGasPrices(lowGasPrice)
+
+	_, err = antehandler(ctx, tx, false)
+	require.Nil(t, err, "Decorator should not have errored on fee higher than local gasPrice")
+}
+
+func TestDeductFees(t *testing.T) {
+	// setup
+	app, ctx := createTestApp(true)
+
+	// keys and addresses
+	priv1, _, addr1 := types.KeyTestPubAddr()
+
+	// msg and signatures
+	msg1 := types.NewTestMsg(addr1)
+	fee := types.NewTestStdFee()
+
+	msgs := []sdk.Msg{msg1}
+
+	privs, accNums, seqs := []crypto.PrivKey{priv1}, []uint64{0}, []uint64{0}
+	tx := types.NewTestTx(ctx, msgs, privs, accNums, seqs, fee)
+
+	// Set account with insufficient funds
+	acc := app.AccountKeeper.NewAccountWithAddress(ctx, addr1)
+	acc.SetCoins([]sdk.Coin{sdk.NewCoin("atom", sdk.NewInt(10))})
+	app.AccountKeeper.SetAccount(ctx, acc)
+
+	dfd := ante.NewDeductFeeDecorator(app.AccountKeeper, app.SupplyKeeper)
+	antehandler := sdk.ChainDecorators(dfd)
+
+	_, err := antehandler(ctx, tx, false)
+
+	require.NotNil(t, err, "Tx did not error when fee payer had insufficient funds")
+
+	// Set account with sufficient funds
+	acc.SetCoins([]sdk.Coin{sdk.NewCoin("atom", sdk.NewInt(200))})
+	app.AccountKeeper.SetAccount(ctx, acc)
+
+	_, err = antehandler(ctx, tx, false)
+
+	require.Nil(t, err, "Tx errored after account has been set with sufficient funds")
+}

x/auth/ante/setup_test.go

@@ -0,0 +1,99 @@
+package ante_test
+
+import (
+	"testing"
+
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	errs "github.com/cosmos/cosmos-sdk/types/errors"
+	"github.com/cosmos/cosmos-sdk/x/auth/ante"
+	"github.com/cosmos/cosmos-sdk/x/auth/types"
+	"github.com/stretchr/testify/require"
+	"github.com/tendermint/tendermint/crypto"
+)
+
+func TestSetup(t *testing.T) {
+	// setup
+	_, ctx := createTestApp(true)
+
+	// keys and addresses
+	priv1, _, addr1 := types.KeyTestPubAddr()
+
+	// msg and signatures
+	msg1 := types.NewTestMsg(addr1)
+	fee := types.NewTestStdFee()
+
+	msgs := []sdk.Msg{msg1}
+
+	privs, accNums, seqs := []crypto.PrivKey{priv1}, []uint64{0}, []uint64{0}
+	tx := types.NewTestTx(ctx, msgs, privs, accNums, seqs, fee)
+
+	sud := ante.NewSetupDecorator()
+	antehandler := sdk.ChainDecorators(sud)
+
+	// Set height to non-zero value for GasMeter to be set
+	ctx = ctx.WithBlockHeight(1)
+
+	// Context GasMeter Limit not set
+	require.Equal(t, uint64(0), ctx.GasMeter().Limit(), "GasMeter set with limit before setup")
+
+	newCtx, err := antehandler(ctx, tx, false)
+	require.Nil(t, err, "SetupDecorator returned error")
+
+	// Context GasMeter Limit should be set after SetupDecorator runs
+	require.Equal(t, fee.Gas, newCtx.GasMeter().Limit(), "GasMeter not set correctly")
+}
+
+func TestRecoverPanic(t *testing.T) {
+	// setup
+	_, ctx := createTestApp(true)
+
+	// keys and addresses
+	priv1, _, addr1 := types.KeyTestPubAddr()
+
+	// msg and signatures
+	msg1 := types.NewTestMsg(addr1)
+	fee := types.NewTestStdFee()
+
+	msgs := []sdk.Msg{msg1}
+
+	privs, accNums, seqs := []crypto.PrivKey{priv1}, []uint64{0}, []uint64{0}
+	tx := types.NewTestTx(ctx, msgs, privs, accNums, seqs, fee)
+
+	sud := ante.NewSetupDecorator()
+	antehandler := sdk.ChainDecorators(sud, OutOfGasDecorator{})
+
+	// Set height to non-zero value for GasMeter to be set
+	ctx = ctx.WithBlockHeight(1)
+
+	newCtx, err := antehandler(ctx, tx, false)
+
+	require.NotNil(t, err, "Did not return error on OutOfGas panic")
+
+	require.True(t, errs.ErrOutOfGas.Is(err), "Returned error is not an out of gas error")
+	require.Equal(t, fee.Gas, newCtx.GasMeter().Limit())
+
+	antehandler = sdk.ChainDecorators(sud, PanicDecorator{})
+	require.Panics(t, func() { antehandler(ctx, tx, false) }, "Recovered from non-Out-of-Gas panic")
+}
+
+type OutOfGasDecorator struct{}
+
+// AnteDecorator that will throw OutOfGas panic
+func (ogd OutOfGasDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bool, next sdk.AnteHandler) (sdk.Context, error) {
+	overLimit := ctx.GasMeter().Limit() + 1
+
+	// Should panic with outofgas error
+	ctx.GasMeter().ConsumeGas(overLimit, "test panic")
+
+	// not reached
+	return next(ctx, tx, simulate)
+}
+
+type PanicDecorator struct{}
+
+func (pd PanicDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bool, next sdk.AnteHandler) (sdk.Context, error) {
+	panic("random error")
+
+	// not reached
+	return ctx, nil
+}

x/auth/types/stdtx_test.go

@@ -49,7 +49,7 @@ func TestStdSignBytes(t *testing.T) {
 	}{
 		{
 			args{"1234", 3, 6, defaultFee, []sdk.Msg{sdk.NewTestMsg(addr)}, "memo"},
-			fmt.Sprintf("{\"account_number\":\"3\",\"chain_id\":\"1234\",\"fee\":{\"amount\":[{\"amount\":\"150\",\"denom\":\"atom\"}],\"gas\":\"50000\"},\"memo\":\"memo\",\"msgs\":[[\"%s\"]],\"sequence\":\"6\"}", addr),
+			fmt.Sprintf("{\"account_number\":\"3\",\"chain_id\":\"1234\",\"fee\":{\"amount\":[{\"amount\":\"150\",\"denom\":\"atom\"}],\"gas\":\"70000\"},\"memo\":\"memo\",\"msgs\":[[\"%s\"]],\"sequence\":\"6\"}", addr),
 		},
 	}
 	for i, tc := range tests {

x/auth/types/test_common.go

@@ -13,7 +13,7 @@ func NewTestMsg(addrs ...sdk.AccAddress) *sdk.TestMsg {
 }
 
 func NewTestStdFee() StdFee {
-	return NewStdFee(50000,
+	return NewStdFee(100000,
 		sdk.NewCoins(sdk.NewInt64Coin("atom", 150)),
 	)
 }