Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 009: Evidence Module #4826

Merged
merged 33 commits into from
Oct 17, 2019
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
9170058
Add evidence module skeleton
alexanderbez Jul 31, 2019
4e10550
Add changelog and context
alexanderbez Jul 31, 2019
555fad0
Change ADR # and update decision section
alexanderbez Aug 1, 2019
8b05233
Add consequences
alexanderbez Aug 1, 2019
c987342
Updates
alexanderbez Aug 1, 2019
64cfb95
Updates
alexanderbez Aug 1, 2019
e9882b8
More updates
alexanderbez Aug 1, 2019
57364a8
Renaming
alexanderbez Aug 1, 2019
b8dfa24
Formatting
alexanderbez Aug 1, 2019
4fee610
Formatting
alexanderbez Aug 1, 2019
bdd8d36
Add TODO section
alexanderbez Aug 1, 2019
23343b1
Add section on mapping
alexanderbez Aug 1, 2019
6500482
Add section on genesis state
alexanderbez Aug 1, 2019
0daeff3
Add section headers
alexanderbez Aug 1, 2019
c641b9e
Add support for jailing
alexanderbez Aug 1, 2019
317d64e
Change ADR to 009
alexanderbez Aug 2, 2019
992dc02
Update context
alexanderbez Aug 9, 2019
9a31020
Update decision points
alexanderbez Aug 9, 2019
beb760c
Update decision points
alexanderbez Aug 9, 2019
b27f0a4
Markdown cleanup
alexanderbez Aug 9, 2019
57969ca
Add further details on the Infraction type
alexanderbez Aug 9, 2019
d929292
Add section on params
alexanderbez Aug 9, 2019
e991117
Update docs on jailable penalties
alexanderbez Aug 9, 2019
bb1fd3e
Merge branch 'master' into bez/adr-evidence-module
alexanderbez Oct 14, 2019
8d3d1de
adr: update context
alexanderbez Oct 15, 2019
5ff4570
adr: fix typos
alexanderbez Oct 15, 2019
e1d963d
Merge branch 'master' into bez/adr-evidence-module
alexanderbez Oct 15, 2019
57d23bd
adr: update decision section features
alexanderbez Oct 16, 2019
c273bb9
adr: simplify evidence slashing logic
alexanderbez Oct 16, 2019
a258585
adr: cleanup evidence interface and add member comments
alexanderbez Oct 16, 2019
074c3e1
adr: update router interface
alexanderbez Oct 16, 2019
56a7a33
Merge branch 'master' into bez/adr-evidence-module
alexanderbez Oct 16, 2019
7df9555
Merge branch 'master' into bez/adr-evidence-module
alexanderbez Oct 17, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add further details on the Infraction type
  • Loading branch information
alexanderbez committed Aug 9, 2019
commit 57969cafebecb748240b51b925f825865bcac1cf
10 changes: 6 additions & 4 deletions docs/architecture/adr-009-evidence-module.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,15 @@ all submitted valid misbehaviour
First, we define the `Evidence` interface type. The `x/evidence` module may implement
its own types that can be used by many chains (e.g. `CounterFactualEvidence`).
In addition, other modules may implement their own `Evidence` types in a similar
manner in which governance is extensible. It is important to note any concrete
manner in which governance is extensible. It is important to note any concrete
type implementing the `Evidence` interface may include arbitrary fields such as
an infraction time. We want the `Evidence` type to remain as flexible
as possible.
an infraction time. We want the `Evidence` type to remain as flexible as possible.

However, when submitting evidence to the `x/evidence` module, it must be submitted
as an `Infraction` which includes mandatory fields outlined below.
as an `Infraction` which includes mandatory fields outlined below. The `Infraction`
type must include the validator's consensus address, which should be known by the
`x/slashing` module, the height at which the infraction occured and the validator's
power at same height in which the infraction occured.

```go
type Evidence interface {
cwgoes marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, we could potentially add Verify and Hash but I wonder what Verify would look like?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expand Down