-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Events Attributes #4772
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4772 +/- ##
==========================================
+ Coverage 53.88% 53.89% +<.01%
==========================================
Files 270 270
Lines 17230 17231 +1
==========================================
+ Hits 9285 9286 +1
Misses 7261 7261
Partials 684 684 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit. otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a state machine breaking and will break the testnet if we try to deploy it there.
Events are not state-machine breaking -- they're not stored in state. Events can be added/removed at will without any breaking changes technically 👍 |
Add some missing event attributes that would be helpful for upstream consumers and clients.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]
Re-reviewed
Files changed
in the github PR explorerFor Admin Use: