Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Events Attributes #4772

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Add New Events Attributes #4772

merged 2 commits into from
Jul 24, 2019

Conversation

alexanderbez
Copy link
Contributor

Add some missing event attributes that would be helpful for upstream consumers and clients.


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #4772 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4772      +/-   ##
==========================================
+ Coverage   53.88%   53.89%   +<.01%     
==========================================
  Files         270      270              
  Lines       17230    17231       +1     
==========================================
+ Hits         9285     9286       +1     
  Misses       7261     7261              
  Partials      684      684

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit. otherwise LGTM

x/bank/internal/types/events.go Outdated Show resolved Hide resolved
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a state machine breaking and will break the testnet if we try to deploy it there.

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Jul 24, 2019

This is a state machine breaking and will break the testnet if we try to deploy it there.

Events are not state-machine breaking -- they're not stored in state. Events can be added/removed at will without any breaking changes technically 👍

@alexanderbez alexanderbez requested a review from fedekunze July 24, 2019 21:35
@alexanderbez alexanderbez merged commit 2b3d785 into master Jul 24, 2019
@alexanderbez alexanderbez deleted the bez/minor-events-updates branch July 24, 2019 22:50
alexanderbez added a commit that referenced this pull request Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants