Merge branch 'master' into gamarin/baseapp

cosmos · jackzampolin · Jul 17, 2019 · May 20, 2019 · May 20, 2019 · May 21, 2019
commit 9aedc16280e58005607092024fdace75531cdd6b
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -50,22 +50,6 @@ jobs:
             - bin
             - profiles
 
-  lint:
-    <<: *linux_defaults
-    parallelism: 1
-    steps:
-      - attach_workspace:
-          at: /tmp/workspace
-      - checkout
-      - restore_cache:
-          keys:
-            - go-mod-v1-{{ checksum "go.sum" }}
-      - run:
-          name: Lint source
-          command: |
-            export PATH=/tmp/workspace/bin:$PATH
-            make ci-lint
-
   test_sim_app_nondeterminism:
     <<: *linux_defaults
     parallelism: 1
@@ -284,9 +268,6 @@ workflows:
             tags:
               only:
                 - /^v.*/
-      - lint:
-          requires:
-            - setup_dependencies
       - test_sim_app_nondeterminism:
           requires:
             - setup_dependencies

diff --git a/.gitignore b/.gitignore
@@ -27,6 +27,7 @@ mytestnet
 # Testing
 coverage.txt
 profile.out
+sim_log_file
 
 # Vagrant
 .vagrant/

diff --git a/.golangci.yml b/.golangci.yml
@@ -7,6 +7,11 @@ linters:
     - unconvert
     - misspell
     - govet
+    - unused
+    - deadcode
+    - goconst
+    - gosec
+    - staticcheck
 linters-settings:
   gocyclo:
     min-complexity: 11

diff --git a/.pending/breaking/sdk/3972-supply b/.pending/breaking/sdk/3972-supply
@@ -0,0 +1,11 @@
+#4255 Add supply module that passively tracks the supplies of a chain
+- Renamed `x/distribution` `ModuleName`
+  - Genesis JSON and CLI now use `distribution` instead of `distr`
+- Introduce `ModuleAccount` type, which tracks the flow of coins held within a module
+- Replaced `FeeCollectorKeeper` for a `ModuleAccount`
+- Replaced the staking `Pool`, which coins are now held by the `BondedPool` and `NotBonded` module accounts
+  - The `NotBonded` module account now only keeps track of the not bonded tokens within staking, instead of the whole chain 
+- #3628 Replaced governance's burn and deposit accounts for a `ModuleAccount`
+- Added a `ModuleAccount` for the distribution module
+- Added a `ModuleAccount` for the mint module
+#4472 validation for crisis genesis
diff --git a/.pending/breaking/sdk/3985-ValidatorPowerR b/.pending/breaking/sdk/3985-ValidatorPowerR
@@ -0,0 +1 @@
+#3985 `ValidatorPowerRank` uses potential consensus power instead of tendermint power
diff --git a/.pending/breaking/sdk/4387-Refactor-the-us b/.pending/breaking/sdk/4387-Refactor-the-us
@@ -0,0 +1,15 @@
+#4387 Refactor the usage of tags (now called events) to reflect the
+new ABCI events semantics:
+
+- Move `x/{module}/tags/tags.go` => `x/{module}/types/events.go`
+- Update `docs/specs`
+- Refactor tags in favor of new `Event(s)` type(s)
+- Update `Context` to use new `EventManager`
+- (Begin|End)Blocker no longer return tags, but rather uses new `EventManager`
+- Message handlers no longer return tags, but rather uses new `EventManager`
+
+Any component (e.g. BeginBlocker, message handler, etc...) wishing to emit an event must do so
+through `ctx.EventManger().EmitEvent(s)`.
+
+To reset or wipe emitted events: `ctx = ctx.WithEventManager(sdk.NewEventManager())`
+To get all emitted events: `events := ctx.EventManager().Events()`
diff --git a/.pending/breaking/sdk/4437-bytes-gov-keys b/.pending/breaking/sdk/4437-bytes-gov-keys
@@ -0,0 +1 @@
+#4437 Replace governance module store keys to use `[]byte` instead of `string`.
diff --git a/.pending/breaking/sdk/4451-Improve-modular b/.pending/breaking/sdk/4451-Improve-modular
@@ -0,0 +1,5 @@
+#4451 Improve modularization of clients and modules:
+  * Module directory structure improved and standardized
+  * Aliases autogenerated
+  * Auth and bank related commands are now mounted under the respective moduels
+  * Client initialization and mounting standardized
diff --git a/.pending/breaking/sdk/4479-Remove-codec-ar b/.pending/breaking/sdk/4479-Remove-codec-ar
@@ -0,0 +1,2 @@
+#4479 Remove codec argument redundency in client usage where
+the CLIContext's codec should be used instead.
diff --git a/.pending/breaking/sdk/4488-client-s-tx-res b/.pending/breaking/sdk/4488-client-s-tx-res
@@ -0,0 +1,2 @@
+#4488 Decouple client tx, REST, and ultil packages from auth. These packages have
+been restructured and retrofitted into the `x/auth` module.
diff --git a/.pending/breaking/sdk/4521-Flatten-x-bank- b/.pending/breaking/sdk/4521-Flatten-x-bank-
@@ -0,0 +1 @@
+#4521 Flatten x/bank structure by hiding module internals.
diff --git a/.pending/breaking/sdk/4525-Remove---cors-f b/.pending/breaking/sdk/4525-Remove---cors-f
@@ -0,0 +1 @@
+#4525 Remove --cors flag, the feature is long gone.
diff --git a/.pending/breaking/sdk/4536-The-auth-accoun b/.pending/breaking/sdk/4536-The-auth-accoun
@@ -0,0 +1,2 @@
+#4536 The `/auth/accounts/{address}` now returns a `height` in the response.
+The account is now nested under `account`.
diff --git a/.pending/breaking/sdk/4543-Account-getters b/.pending/breaking/sdk/4543-Account-getters
@@ -0,0 +1,2 @@
+#4543 Account getters are no longer part of client.CLIContext() and have now moved
+to reside in the auth-specific AccountRetriever.
diff --git a/.pending/breaking/sdk/4588-Context-does-no b/.pending/breaking/sdk/4588-Context-does-no
@@ -0,0 +1,6 @@
+#4588 Context does not depend on x/auth anymore. client/context is stripped out of the following features:
+- GetAccountDecoder()
+- CLIContext.WithAccountDecoder()
+- CLIContext.WithAccountStore()
+
+x/auth.AccountDecoder is unnecessary and consequently removed.
diff --git a/.pending/breaking/sdk/4602-client-input-Bu b/.pending/breaking/sdk/4602-client-input-Bu
@@ -0,0 +1 @@
+#4602 client/input.{Buffer,Override}Stdin() functions are removed. Thanks to cobra's new release they are now redundant.
diff --git a/.pending/breaking/sdk/4633-Update-old-Tx-s b/.pending/breaking/sdk/4633-Update-old-Tx-s
@@ -0,0 +1,2 @@
+#4633 Update old Tx search by tags APIs to use new Events
+nomenclature. 
diff --git a/.pending/breaking/sdk/4649-Refactor-x-cris b/.pending/breaking/sdk/4649-Refactor-x-cris
@@ -0,0 +1 @@
+#4649 Refactor x/crisis as per modules new specs.
diff --git a/.pending/breaking/sdk/refactor-bank-keeper b/.pending/breaking/sdk/refactor-bank-keeper
@@ -0,0 +1,2 @@
+#4663 Refactor bank keeper by removing private functions
+  - `InputOutputCoins`, `SetCoins`, `SubtractCoins` and `AddCoins` are now part of the `SendKeeper` instead of the `Keeper` interface
diff --git a/.pending/bugfixes/sdk/1351-https-github-co b/.pending/bugfixes/sdk/1351-https-github-co
@@ -0,0 +1 @@
+[\#1351](https://github.com/cosmos/cosmos-sdk/issues/1351) Stable AppHash allows no_empty_blocks
diff --git a/.pending/bugfixes/sdk/4455-Print-null-whil b/.pending/bugfixes/sdk/4455-Print-null-whil
@@ -0,0 +1 @@
+#4455 Use `QueryWithData()` to query unbonding delegations.
diff --git a/.pending/bugfixes/sdk/4493-Fix-validator-o b/.pending/bugfixes/sdk/4493-Fix-validator-o
@@ -0,0 +1,2 @@
+#4493 Fix validator-outstanding-rewards command. It now takes as an argument
+a validator address.
diff --git a/.pending/bugfixes/sdk/4598-fix-check-bond- b/.pending/bugfixes/sdk/4598-fix-check-bond-
@@ -0,0 +1 @@
+#4598 Fix redelegation and undelegation txs that were not checking for the correct bond denomination.
diff --git a/.pending/bugfixes/sdk/4619-Close-iterators b/.pending/bugfixes/sdk/4619-Close-iterators
@@ -0,0 +1,2 @@
+#4619 Close iterators in `GetAllMatureValidatorQueue` and `UnbondAllMatureValidatorQueue`
+methods.
diff --git a/.pending/bugfixes/sdk/4654-validator-slash b/.pending/bugfixes/sdk/4654-validator-slash
@@ -0,0 +1 @@
+#4654 validator slash event stored by period and height
diff --git a/.pending/bugfixes/sdk/4681-mint-check b/.pending/bugfixes/sdk/4681-mint-check
@@ -0,0 +1,2 @@
+#4681 panic on invalid amount on `MintCoins` and `BurnCoins`
+  - skip minting if inflation is set to zero
diff --git a/.pending/features/sdk/4409-migration-scrip b/.pending/features/sdk/4409-migration-scrip
@@ -0,0 +1,3 @@
+#4409 Implement a command that migrates exported state from one version to the next.
+The `migrate` command currently supports migrating from v0.34 to v0.36 by implementing
+necessary types for both versions.
diff --git a/.pending/features/sdk/4570-Move-bank-balan b/.pending/features/sdk/4570-Move-bank-balan
@@ -0,0 +1 @@
+#4570 Move /bank/balances/{address} REST handler to x/bank/client/rest. The exposed interface is unchanged.
diff --git a/.pending/improvements/sdk/3512-Implement-Logge b/.pending/improvements/sdk/3512-Implement-Logge
@@ -0,0 +1 @@
+#3512 Implement Logger method on each module's keeper.
diff --git a/.pending/improvements/sdk/3928-remove-types-staking b/.pending/improvements/sdk/3928-remove-types-staking
@@ -0,0 +1,2 @@
+#3928 remove staking references from types package
+#1528 define local module interfaces instead of /types 
diff --git a/.pending/improvements/sdk/4439-add-governance- b/.pending/improvements/sdk/4439-add-governance-
@@ -0,0 +1 @@
+#4439 Implement governance module iterators.
diff --git a/.pending/improvements/sdk/4465-Unknown-subcomm b/.pending/improvements/sdk/4465-Unknown-subcomm
@@ -0,0 +1 @@
+#4465 Unknown subcommands print relevant error message
diff --git a/.pending/improvements/sdk/4466-Commission-vali b/.pending/improvements/sdk/4466-Commission-vali
@@ -0,0 +1 @@
+#4466 Commission validation added to validate basic of MsgCreateValidator by changing CommissionMsg to CommissionRates
diff --git a/.pending/improvements/sdk/4501-Support-height- b/.pending/improvements/sdk/4501-Support-height-
@@ -0,0 +1 @@
+#4501 Support height queriers in rest client
diff --git a/.pending/improvements/sdk/4535-improve-sim-err b/.pending/improvements/sdk/4535-improve-sim-err
@@ -0,0 +1,2 @@
+#4535 Improve import-export simulation errors by decoding the `KVPair.Value` into its
+respective type
diff --git a/.pending/improvements/sdk/4536-cli-context-que b/.pending/improvements/sdk/4536-cli-context-que
@@ -0,0 +1 @@
+#4536 cli context queries return query height and accounts are returned with query height
diff --git a/.pending/improvements/sdk/4553-undelegate-max-entries-check-first b/.pending/improvements/sdk/4553-undelegate-max-entries-check-first
@@ -0,0 +1 @@
+#4553 undelegate max entries check first
diff --git a/.pending/improvements/sdk/4556-Added-IsValid-f b/.pending/improvements/sdk/4556-Added-IsValid-f
@@ -0,0 +1 @@
+#4556 Added IsValid function to Coin
diff --git a/.pending/improvements/sdk/4564-Allow-empty-ans b/.pending/improvements/sdk/4564-Allow-empty-ans
@@ -0,0 +1 @@
+#4564 client/input.GetConfirmation()'s default is changed to No.
diff --git a/.pending/improvements/sdk/4573-adds-height-in- b/.pending/improvements/sdk/4573-adds-height-in-
@@ -0,0 +1 @@
+#4573 Returns height in response for query endpoints.
diff --git a/.pending/improvements/sdk/4580-remove-block-he b/.pending/improvements/sdk/4580-remove-block-he
@@ -0,0 +1 @@
+#4580 Update `Context#BlockHeight` to properly set the block height via `WithBlockHeader`.
diff --git a/.pending/improvements/sdk/4584-Update-bank-Kee b/.pending/improvements/sdk/4584-Update-bank-Kee
@@ -0,0 +1,2 @@
+#4584 Update bank Keeper to use expected keeper interface of the AccountKeeper.
+#4584 Move `Account` and `VestingAccount` interface types to `x/auth/exported`.
diff --git a/.pending/improvements/sdk/4595-supply-queriers b/.pending/improvements/sdk/4595-supply-queriers
@@ -0,0 +1 @@
+#4082 supply module queriers for CLI and REST endpoints
diff --git a/.pending/improvements/sdk/4601-Implement-gener b/.pending/improvements/sdk/4601-Implement-gener
@@ -0,0 +1,2 @@
+#4601 Implement generic pangination helper function to be used in
+REST handlers and queriers.
diff --git a/.pending/improvements/sdk/4629-Added-event-that-get b/.pending/improvements/sdk/4629-Added-event-that-get
@@ -0,0 +1 @@
+#4629 Added warning event that gets emitted if validator misses a block.
diff --git a/.pending/improvements/sdk/4676-expose-simapp-f b/.pending/improvements/sdk/4676-expose-simapp-f
@@ -0,0 +1 @@
+#4674 Export `Simapp` genState generators and util functions by making them public
diff --git a/.pending/improvements/sdk/Remove---print-respo b/.pending/improvements/sdk/Remove---print-respo
@@ -0,0 +1 @@
+Remove `--print-response` flag as it is no longer used.
diff --git a/.pending/improvements/sdk/Revert-2284-https-gi b/.pending/improvements/sdk/Revert-2284-https-gi
@@ -0,0 +1 @@
+Revert (#2284)[https://github.com/cosmos/cosmos-sdk/pull/2284] to allow create_empty_blocks in the config
diff --git a/Makefile b/Makefile
@@ -7,6 +7,7 @@ COMMIT := $(shell git log -1 --format='%H')
 LEDGER_ENABLED ?= true
 BINDIR ?= $(GOPATH)/bin
 SIMAPP = github.com/cosmos/cosmos-sdk/simapp
+MOCKS_DIR = $(CURDIR)/tests/mocks
 
 export GO111MODULE = on
 
@@ -33,6 +34,12 @@ dist:
 	@bash publish/dist.sh
 	@bash publish/publish.sh
 
+mocks: $(MOCKS_DIR)
+	mockgen -source=x/auth/types/account_retriever.go -package mocks -destination tests/mocks/account_retriever.go
+
+$(MOCKS_DIR):
+	mkdir -p $(MOCKS_DIR)
+
 ########################################
 ### Tools & dependencies
 
@@ -43,6 +50,7 @@ go-mod-cache: go.sum
 go.sum: go.mod
 	@echo "--> Ensure dependencies have not been modified"
 	@go mod verify
+	@go mod tidy
 
 clean:
 	rm -rf snapcraft-local.yaml build/
@@ -118,8 +126,9 @@ test_sim_benchmark_invariants:
 
 # Don't move it into tools - this will be gone once gaia has moved into the new repo
 runsim: $(BINDIR)/runsim
-$(BINDIR)/runsim: contrib/runsim/main.go
-	go install github.com/cosmos/cosmos-sdk/contrib/runsim
+$(BINDIR)/runsim:
+	go get github.com/cosmos/tools/cmd/runsim/
+	go mod tidy
 
 SIM_NUM_BLOCKS ?= 500
 SIM_BLOCK_SIZE ?= 200
@@ -138,8 +147,7 @@ test_sim_app_profile:
 test_cover:
 	@export VERSION=$(VERSION); bash -x tests/test_cover.sh
 
-lint: tools ci-lint
-ci-lint:
+lint: golangci-lint
 	golangci-lint run
 	find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" | xargs gofmt -d -s
 	go mod verify
@@ -186,7 +194,7 @@ snapcraft-local.yaml: snapcraft-local.yaml.in
 # To avoid unintended conflicts with file names, always add to .PHONY
 # unless there is a reason not to.
 # https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
-.PHONY: build dist clean test test_unit test_cover lint \
+.PHONY: build dist clean test test_unit test_cover lint mocks \
 benchmark devdoc_init devdoc devdoc_save devdoc_update runsim \
 format test_sim_app_nondeterminism test_sim_modules test_sim_app_fast \
 test_sim_app_custom_genesis_fast test_sim_app_custom_genesis_multi_seed \

diff --git a/README.md b/README.md
@@ -1,9 +1,8 @@
 # Cosmos SDK
-![banner](docs/cosmos-sdk-image.png)
+![banner](docs/cosmos-sdk-image.jpg)
 
 [![version](https://img.shields.io/github/tag/cosmos/cosmos-sdk.svg)](https://github.com/cosmos/cosmos-sdk/releases/latest)
 [![CircleCI](https://circleci.com/gh/cosmos/cosmos-sdk/tree/master.svg?style=shield)](https://circleci.com/gh/cosmos/cosmos-sdk/tree/master)
-[![Snap Status](https://build.snapcraft.io/badge/cosmos/cosmos-sdk.svg)](https://build.snapcraft.io/user/cosmos/cosmos-sdk)
 [![codecov](https://codecov.io/gh/cosmos/cosmos-sdk/branch/master/graph/badge.svg)](https://codecov.io/gh/cosmos/cosmos-sdk)
 [![Go Report Card](https://goreportcard.com/badge/github.com/cosmos/cosmos-sdk)](https://goreportcard.com/report/github.com/cosmos/cosmos-sdk)
 [![license](https://img.shields.io/github/license/cosmos/cosmos-sdk.svg)](https://github.com/cosmos/cosmos-sdk/blob/master/LICENSE)

diff --git a/baseapp/baseapp.go b/baseapp/baseapp.go
@@ -627,14 +627,14 @@ func (app *BaseApp) BeginBlock(req abci.RequestBeginBlock) (res abci.ResponseBeg
 // the route match to see whether a handler exists.
 //
 // NOTE:CheckTx does not run the actual Msg handler function(s).
-func (app *BaseApp) CheckTx(txBytes []byte) (res abci.ResponseCheckTx) {
+func (app *BaseApp) CheckTx(req abci.RequestCheckTx) (res abci.ResponseCheckTx) {
 	var result sdk.Result
 
-	tx, err := app.txDecoder(txBytes)
+	tx, err := app.txDecoder(req.Tx)
 	if err != nil {
 		result = err.Result()
 	} else {
-		result = app.runTx(runTxModeCheck, txBytes, tx)
+		result = app.runTx(runTxModeCheck, req.Tx, tx)
 	}
 
 	return abci.ResponseCheckTx{
@@ -643,19 +643,19 @@ func (app *BaseApp) CheckTx(txBytes []byte) (res abci.ResponseCheckTx) {
 		Log:       result.Log,
 		GasWanted: int64(result.GasWanted), // TODO: Should type accept unsigned ints?
 		GasUsed:   int64(result.GasUsed),   // TODO: Should type accept unsigned ints?
-		Tags:      result.Tags,
+		Events:    result.Events.ToABCIEvents(),
 	}
 }
 
 // DeliverTx implements the ABCI interface.
-func (app *BaseApp) DeliverTx(txBytes []byte) (res abci.ResponseDeliverTx) {
+func (app *BaseApp) DeliverTx(req abci.RequestDeliverTx) (res abci.ResponseDeliverTx) {
 	var result sdk.Result
 
-	tx, err := app.txDecoder(txBytes)
+	tx, err := app.txDecoder(req.Tx)
 	if err != nil {
 		result = err.Result()
 	} else {
-		result = app.runTx(runTxModeDeliver, txBytes, tx)
+		result = app.runTx(runTxModeDeliver, req.Tx, tx)
 	}
 
 	return abci.ResponseDeliverTx{
@@ -665,7 +665,7 @@ func (app *BaseApp) DeliverTx(txBytes []byte) (res abci.ResponseDeliverTx) {
 		Log:       result.Log,
 		GasWanted: int64(result.GasWanted), // TODO: Should type accept unsigned ints?
 		GasUsed:   int64(result.GasUsed),   // TODO: Should type accept unsigned ints?
-		Tags:      result.Tags,
+		Events:    result.Events.ToABCIEvents(),
 	}
 }
 
@@ -705,11 +705,15 @@ func (app *BaseApp) getContextForTx(mode runTxMode, txBytes []byte) (ctx sdk.Con
 func (app *BaseApp) runMsgs(ctx sdk.Context, msgs []sdk.Msg, mode runTxMode) (result sdk.Result) {
 	idxLogs := make([]sdk.ABCIMessageLog, 0, len(msgs)) // a list of JSON-encoded logs with msg index
 
-	var data []byte   // NOTE: we just append them all (?!)
-	var tags sdk.Tags // also just append them all
-	var code sdk.CodeType
-	var codespace sdk.CodespaceType
+	var (
+		data      []byte
+		code      sdk.CodeType
+		codespace sdk.CodespaceType
+	)
 
+	events := sdk.EmptyEvents()
+
+	// NOTE: GasWanted is determined by ante handler and GasUsed by the GasMeter.
 	for msgIdx, msg := range msgs {
 		// match message route
 		msgRoute := msg.Route()
@@ -725,12 +729,13 @@ func (app *BaseApp) runMsgs(ctx sdk.Context, msgs []sdk.Msg, mode runTxMode) (re
 			msgResult = handler(ctx, msg)
 		}
 
-		// NOTE: GasWanted is determined by ante handler and GasUsed by the GasMeter.
-
-		// Result.Data must be length prefixed in order to separate each result
+		// Each message result's Data must be length prefixed in order to separate
+		// each result.
 		data = append(data, msgResult.Data...)
-		tags = append(tags, sdk.MakeTag(sdk.TagAction, msg.Type()))
-		tags = append(tags, msgResult.Tags...)
+
+		// append events from the message's execution and a message action event
+		events = events.AppendEvent(sdk.NewEvent(sdk.EventTypeMessage, sdk.NewAttribute(sdk.AttributeKeyAction, msg.Type())))
+		events = events.AppendEvents(msgResult.Events)
 
 		idxLog := sdk.ABCIMessageLog{MsgIndex: uint16(msgIdx), Log: msgResult.Log}
 
@@ -755,7 +760,7 @@ func (app *BaseApp) runMsgs(ctx sdk.Context, msgs []sdk.Msg, mode runTxMode) (re
 		Data:      data,
 		Log:       strings.TrimSpace(string(logJSON)),
 		GasUsed:   ctx.GasMeter().GasConsumed(),
-		Tags:      tags,
+		Events:    events,
 	}
 
 	return result
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		#3985 `ValidatorPowerRank` uses potential consensus power instead of tendermint power
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		#4437 Replace governance module store keys to use `[]byte` instead of `string`.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		#4479 Remove codec argument redundency in client usage where
		the CLIContext's codec should be used instead.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		#4488 Decouple client tx, REST, and ultil packages from auth. These packages have
		been restructured and retrofitted into the `x/auth` module.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		#4521 Flatten x/bank structure by hiding module internals.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		#4525 Remove --cors flag, the feature is long gone.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		#4536 The `/auth/accounts/{address}` now returns a `height` in the response.
		The account is now nested under `account`.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		#4543 Account getters are no longer part of client.CLIContext() and have now moved
		to reside in the auth-specific AccountRetriever.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		#4602 client/input.{Buffer,Override}Stdin() functions are removed. Thanks to cobra's new release they are now redundant.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		#4633 Update old Tx search by tags APIs to use new Events
		nomenclature.