Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/supply: use internal package #4661

Merged
merged 4 commits into from
Jul 2, 2019
Merged

x/supply: use internal package #4661

merged 4 commits into from
Jul 2, 2019

Conversation

fedekunze
Copy link
Collaborator

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze marked this pull request as ready for review July 2, 2019 13:56
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #4661 into master will increase coverage by <.01%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master    #4661      +/-   ##
==========================================
+ Coverage   54.78%   54.78%   +<.01%     
==========================================
  Files         269      269              
  Lines       16907    16917      +10     
==========================================
+ Hits         9262     9268       +6     
- Misses       6963     6967       +4     
  Partials      682      682

@fedekunze fedekunze changed the title supply/internal pkg x/supply: use internal package Jul 2, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 179476d into master Jul 2, 2019
@alexanderbez alexanderbez deleted the supply-internal branch July 2, 2019 16:24
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants