Implement logger interface on keeper. #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a logger interface to the keeper for modules where it wasn't defined. - In the crisis module, removed the passing of the logger as a parameter in abci.go and module.go
aayushijain23
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
alexanderbez
added
WIP
Type: Code Hygiene
…ses to fail. - Added a change log entry for the code changes. - Implemented a better pattern for module keepers. - Removed logger being passed as a parameter in the test files that were failing.
fedekunze
suggested changes
Jun 25, 2019
There was a problem hiding this comment.
Thanks @aayushijain23 ! I believe we need to have a discussion if every Keeper should have a Logger or not. In some of the cases presented here, it's not even being used.
fedekunze
reviewed
Jun 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #4625 +/- ##
==========================================
+ Coverage 54.11% 54.11% +<.01%
==========================================
Files 260 260
Lines 16364 16373 +9
==========================================
+ Hits 8855 8861 +6
- Misses 6863 6866 +3
Partials 646 646 |
alexanderbez
approved these changes
Jun 26, 2019
fedekunze
approved these changes
Jun 26, 2019
|
@aayushijain23 can you resolve merge conflicts please? |
…implement-logger-interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #3512
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: