-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Don't Burn Deposits for Rejected Governance Proposals Unless Vetoed #4374
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4374 +/- ##
==========================================
- Coverage 58.1% 58.08% -0.03%
==========================================
Files 235 235
Lines 14879 14881 +2
==========================================
- Hits 8646 8643 -3
- Misses 5605 5608 +3
- Partials 628 630 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, probably needs an sdkch
entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM this should also help on the related issue on REST 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 👌
closes #4373 as per Cosmos Hub Governance Proposal 6.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: