R4R simulator bugfix for multisim 7601778 #4365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelrozanski
requested review from
alessio,
alexanderbez and
jackzampolin
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4365 +/- ##
=======================================
Coverage 58.11% 58.11%
=======================================
Files 235 235
Lines 14880 14880
=======================================
Hits 8647 8647
Misses 5605 5605
Partials 628 628 |
npinto
reviewed
May 18, 2019
| @@ -134,7 +134,7 @@ func RandomParams(r *rand.Rand) Params { | |||
| PastEvidenceFraction: r.Float64(), | |||
| NumKeys: RandIntBetween(r, 2, 250), | |||
| EvidenceFraction: r.Float64(), | |||
| InitialLivenessWeightings: []int{r.Intn(80), r.Intn(10), r.Intn(10)}, | |||
| InitialLivenessWeightings: []int{RandIntBetween(r, 1, 80), r.Intn(10), r.Intn(10)}, | |||
There was a problem hiding this comment.
Would it make sense to "protect" the last two parameters to be above 0 as well? If not, maybe another sampling procedure would be required to insure that the sum > 0. What do you think?
There was a problem hiding this comment.
What I mean by that is that any of these values (single one or two of them) being 0 is valid, what is not is if they are all 0.
There was a problem hiding this comment.
Nope I don't think it matters, As long as there is "some" liveliness we're good aka "protecting" just one of the weightings is fine. I think it's good to simulate with a liveliness weighting of 0 as it's a valid value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4362
For the record what was happening is all three integers set in
InitialLivenessWeightingswere set to 0 making the "total" of that equal to zero which caused an error for rand here:cosmos-sdk/x/simulation/transition_matrix.go
Line 61 in a23eb32
docs/)clog add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: