Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Fixes #4353

Merged
merged 2 commits into from
May 17, 2019
Merged

Documentation Fixes #4353

merged 2 commits into from
May 17, 2019

Conversation

tac0turtle
Copy link
Member

Fixed broken links, spelling and added documentation in places.

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • [ n/a ] Linked to github-issue with discussion and accepted design OR link to spec that describes this work. -Dosumnetion fix

  • Wrote tests

  • [ x ] Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • [ x ] rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Fixed broken links, spelling and added documentaiton in places.

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #4353 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4353      +/-   ##
=========================================
+ Coverage   58.08%   58.1%   +0.01%     
=========================================
  Files         235     235              
  Lines       14881   14882       +1     
=========================================
+ Hits         8644    8647       +3     
+ Misses       5609    5607       -2     
  Partials      628     628

1 similar comment
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #4353 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4353      +/-   ##
=========================================
+ Coverage   58.08%   58.1%   +0.01%     
=========================================
  Files         235     235              
  Lines       14881   14882       +1     
=========================================
+ Hits         8644    8647       +3     
+ Misses       5609    5607       -2     
  Partials      628     628

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marbar3778 :)

@alexanderbez alexanderbez added T:Docs Changes and features related to documentation. ready-for-review labels May 17, 2019
@alexanderbez alexanderbez merged commit c0d8fb8 into cosmos:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants