Update REST Client to Support Custom R/W Timeouts #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
WIP
T: Dev UX
alexanderbez
requested review from
alessio,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4285 +/- ##
==========================================
+ Coverage 59.1% 59.11% +<.01%
==========================================
Files 217 217
Lines 14595 14597 +2
==========================================
+ Hits 8627 8629 +2
Misses 5330 5330
Partials 638 638 |
alessio
reviewed
May 7, 2019
| server.TrapSignal(func() { | ||
| err := rs.listener.Close() | ||
| rs.log.Error("error closing listener", "err", err) | ||
| }) | ||
|
|
||
| cfg := rpcserver.DefaultConfig() |
There was a problem hiding this comment.
Why are you dropping DefaultConfig()? Couldn't we override only the values that we want to override and fallback to the defaults?
There was a problem hiding this comment.
Because there is no longer a need for DefaultConfig(). Config is defined by three values which we each set manually. ie. the call would be redundant.
alessio
reviewed
May 7, 2019
alessio
approved these changes
May 7, 2019
rigelrozanski
approved these changes
May 7, 2019
| cmd.Flags().Int(FlagMaxOpenConnections, 1000, "The number of maximum open connections") | ||
| cmd.Flags().Uint(FlagMaxOpenConnections, 1000, "The number of maximum open connections") | ||
| cmd.Flags().Uint(FlagRPCReadTimeout, 10, "The RPC read timeout (in seconds)") | ||
| cmd.Flags().Uint(FlagRPCWriteTimeout, 10, "The RPC write timeout (in seconds)") |
There was a problem hiding this comment.
Is this the timeout in order to receive conformation that your write request was successful? Like what is a rest write?
There was a problem hiding this comment.
@rigelrozanski yeah, the write timeout, from the REST client pov, is mainly for broadcasting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4263
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: