Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4F: Fix typos and something outdated in CONTRIBUTING.md #4132

Merged
merged 1 commit into from
Apr 16, 2019
Merged

R4F: Fix typos and something outdated in CONTRIBUTING.md #4132

merged 1 commit into from
Apr 16, 2019

Conversation

yangyanqing
Copy link
Contributor

@yangyanqing yangyanqing commented Apr 16, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yangyanqing yangyanqing changed the title Fix typos and something outdated in CONTRIBUTING.md R4F: Fix typos and something outdated in CONTRIBUTING.md Apr 16, 2019
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #4132 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #4132      +/-   ##
==========================================
- Coverage    60.12%   60.1%   -0.02%     
==========================================
  Files          211     211              
  Lines        15138   15138              
==========================================
- Hits          9101    9099       -2     
- Misses        5415    5417       +2     
  Partials       622     622

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise LGTM. Thank you.

.pending/improvements/sdk/4132-Fix-typos-and-s Outdated Show resolved Hide resolved
@alessio alessio merged commit 356e819 into cosmos:develop Apr 16, 2019
@yangyanqing yangyanqing deleted the frank/fix-typo-of-contributing branch April 16, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants