New Makefile for gaia #4110
Merged
New Makefile for gaia #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4110 +/- ##
===========================================
+ Coverage 59.97% 60.01% +0.03%
===========================================
Files 211 211
Lines 15111 15111
===========================================
+ Hits 9063 9069 +6
+ Misses 5428 5422 -6
Partials 620 620 |
Amend targets naming convention as per [1]: - Switch from underscore '_' separated naming scheme to dash '-' separated naming scheme. - Replace test with check. Simulations now live in their own Make module. [1] https://www.gnu.org/prep/standards/html_node/Standard-Targets.html
alessio
force-pushed
the
alessio/gaia-makefile
branch
from
5496dc2 to
22821c9
Compare
alessio
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
| ######################################## | ||
| ### Simulations | ||
|
|
||
| sim-gaia-nondeterminism: |
There was a problem hiding this comment.
There aren't meant to be actually executable atm, correct?
cd cmd/gaia; make sim-gaia-fast
Running quick Gaia simulation. This may take several minutes...
can't load package: package github.com/cosmos/cosmos-sdk/cmd/gaia/cmd/gaia/app: unknown import path "github.com/cosmos/cosmos-sdk/cmd/gaia/cmd/gaia/app": cannot find package
make: *** [sim-gaia-fast] Error 1
There was a problem hiding this comment.
No, not quite yet. I've dropped them there as prep work for next iteration.
There was a problem hiding this comment.
I tried to fix them anyway
alessio
force-pushed
the
alessio/gaia-makefile
branch
from
80e2173 to
eb617d0
Compare
|
Looks like this is failing |
|
@alexanderbez but it doesn't look like the failure is caused by the Makefile changes |
alexanderbez
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amend targets naming convention as per [1]:
separated naming scheme.
Simulations now live in their own Make module.
[1] https://www.gnu.org/prep/standards/html_node/Standard-Targets.html
Closes: #4102
docs/)sdkch add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: