Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick docs update to develop #3965

Merged
merged 5 commits into from
Mar 22, 2019
Merged

Conversation

gamarin2
Copy link
Contributor

Cherry pick #3922 to develop

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #3965 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3965   +/-   ##
========================================
  Coverage    60.45%   60.45%           
========================================
  Files          196      196           
  Lines        14488    14488           
========================================
  Hits          8759     8759           
  Misses        5148     5148           
  Partials       581      581

@jackzampolin jackzampolin merged commit 294ac8e into develop Mar 22, 2019
@jackzampolin jackzampolin deleted the gamarin/docs-cherry-pick branch March 22, 2019 20:53
@alexanderbez alexanderbez mentioned this pull request Apr 3, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants