Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdkch various changes #3950

Merged
merged 2 commits into from
Mar 20, 2019
Merged

sdkch various changes #3950

merged 2 commits into from
Mar 20, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 20, 2019 •
edited
Loading

Make sdkch generate skip empty sections/stanzas entirely.

Remove -prune flag, it makes very little sense as git rm -r .pending/ is the effective way to remove pending entries.

Add prune command to prune empty .pending subdirectories.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

alessio added 2 commits March 20, 2019 14:00
@alessio
generate: hide empty sections/stanzas if empty
4b91909
@alessio
Remove -prune flag.
2832941 
-prune is unnecessary and misleading. Once a release is cut,
.pending/ contents must be recursively removed by git rm -r
and changes committed and pushed.

Ref #3892
@alessio
Copy link
Contributor Author

alessio commented Mar 20, 2019

cc @rigelrozanski

@alessio alessio marked this pull request as ready for review March 20, 2019 13:51
@jackzampolin jackzampolin merged commit ae215a2 into develop Mar 20, 2019
@jackzampolin jackzampolin deleted the sdkch-changes branch March 20, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@jleni jleni Awaiting requested review from jleni

@mossid mossid Awaiting requested review from mossid

@sabau sabau Awaiting requested review from sabau

@sunnya97 sunnya97 Awaiting requested review from sunnya97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio @jackzampolin @rigelrozanski