R4R: Fix #3899, Using gaiacli config node breaks ~/config/config.toml
#3903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangyanqing
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Config file need to be truncated while rewriting.
Codecov Report
@@ Coverage Diff @@
## develop #3903 +/- ##
===========================================
- Coverage 60.92% 60.27% -0.65%
===========================================
Files 192 195 +3
Lines 14359 14592 +233
===========================================
+ Hits 8748 8796 +48
- Misses 5037 5211 +174
- Partials 574 585 +11 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #3903 +/- ##
===========================================
- Coverage 60.92% 60.27% -0.65%
===========================================
Files 192 195 +3
Lines 14359 14592 +233
===========================================
+ Hits 8748 8796 +48
- Misses 5037 5211 +174
- Partials 574 585 +11 |
yangyanqing
changed the title
gaiacli config node breaks ~/config/config.tomlgaiacli config node breaks ~/config/config.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config file need to be truncated while rewriting.
close: #3899
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: