Mainnet docs update to master #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamarin2
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
alexanderbez
previously requested changes
Mar 11, 2019
| cosmos-sdk: 0.31.2-10-g1fba7308 | ||
| git commit: 1fba7308fa226e971964cd6baad9527d4b51d9fc | ||
| vendor hash: 1aec7edfad9888a967b3e9063e42f66b28f447e6 | ||
| cosmos-sdk: 0.33.0 |
There was a problem hiding this comment.
This section is wrong. Should be:
cosmos-sdk: 0.33.0
git commit: 06f741609bbce747643e9f1f2abf67040ad78e16
vendor hash: decf1ff8b31df2243aa27bcd6e1a40df4d30be81
build tags: netgo ledger
go version go1.11 darwin/amd64
There was a problem hiding this comment.
Maybe I'm doing something wrong or maybe the tag is bad:
$ git checkout v0.33.0; make distclean vendor-deps install; gaiacli version --long
cosmos-sdk: 0.33.0
git commit: 06f741609bbce747643e9f1f2abf67040ad78e16
vendor hash: decf1ff8b31df2243aa27bcd6e1a40df4d30be81
build tags: netgo ledger
go version go1.11 darwin/amd64
There was a problem hiding this comment.
cosmos-sdk: 0.33.0
git commit: 7b4104aced52aa5b59a96c28b5ebeea7877fc4f0
vendor hash: 5db0df3e24cf10545c84f462a24ddc61882aa58f
build tags: netgo ledger
go version go1.12 linux/amd64Try pulling? I think the v0.33.0 tag was overwritten once.
docs/gaia/gaiacli.md
Outdated
|
|
||
| e.g. | ||
|
|
||
| ```bash | ||
| gaiacli tx send ... --fees=100photino | ||
| gaiacli tx send ... --fees=1000000uatom |
There was a problem hiding this comment.
This suggests a fee of 1atom which seems very high. Shall we use a uatom value that actually represents ~$0.05?
There was a problem hiding this comment.
still needs to be updated I think
Codecov Report
@@ Coverage Diff @@
## master #3855 +/- ##
=======================================
Coverage 60.84% 60.84%
=======================================
Files 192 192
Lines 14288 14288
=======================================
Hits 8694 8694
Misses 5027 5027
Partials 567 567 |
jackzampolin
approved these changes
Mar 11, 2019
ebuchman
reviewed
Mar 11, 2019
Co-Authored-By: jackzampolin <jack.zampolin@gmail.com>
melekes
reviewed
Mar 13, 2019
docs/gaia/gaiacli.md
Outdated
| @@ -366,7 +361,7 @@ where `[name]` is the name of the key you specified when you initialized `gaiad` | |||
| While tokens are bonded, they are pooled with all the other bonded tokens in the network. Validators and delegators obtain a percentage of shares that equal their stake in this pool. | |||
|
|
|||
| ::: tip Note | |||
| Don't use more `steak` thank you have! You can always get more by using the [Faucet](https://faucetcosmos.network/)! | |||
| Don't use more `uatom` than you have! You can always get more by using the [Faucet](https://faucetcosmos.network/)! | |||
There was a problem hiding this comment.
This is only fair for the testnet, no?
docs/gaia/installation.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| ## Install Gaia | |||
|
|
|||
| This guide will explain how to install the `gaiad` and `gaiacli` entrypoints onto your system. With these installed on a server, you can participate in the latest testnet as either a [Full Node](./join-testnet.md#run-a-full-node) or a [Validator](./validators/validator-setup.md). | |||
| This guide will explain how to install the `gaiad` and `gaiacli` entrypoints onto your system. With these installed on a server, you can participate in the latest testnet as either a [Full Node](./join-mainnet.md) or a [Validator](./validators/validator-setup.md). | |||
There was a problem hiding this comment.
"in the latest testnet" -> "in the mainnet"
cwgoes
approved these changes
Mar 13, 2019
docs/gaia/gaiacli.md
Outdated
|
|
||
| e.g. | ||
|
|
||
| ```bash | ||
| gaiacli tx send ... --fees=100photino | ||
| gaiacli tx send ... --fees=1000000uatom |
There was a problem hiding this comment.
still needs to be updated I think
docs/gaia/gaiacli.md
Outdated
| @@ -556,10 +547,10 @@ gaiacli query gov proposer <proposal_id> | |||
|
|
|||
| #### Increase deposit | |||
|
|
|||
| In order for a proposal to be broadcasted to the network, the amount deposited must be above a `minDeposit` value (default: `10 steak`). If the proposal you previously created didn't meet this requirement, you can still increase the total amount deposited to activate it. Once the minimum deposit is reached, the proposal enters voting period: | |||
| In order for a proposal to be broadcasted to the network, the amount deposited must be above a `minDeposit` value (default: `512000000uatom`). If the proposal you previously created didn't meet this requirement, you can still increase the total amount deposited to activate it. Once the minimum deposit is reached, the proposal enters voting period: | |||
There was a problem hiding this comment.
512 Atoms is not the default, it's just the value used by the Cosmos Hub.
Co-Authored-By: gamarin2 <gautier@tendermint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #3838 to master
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: