Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Convenience ToDec() #3680

Merged
merged 7 commits into from
Feb 21, 2019
Merged

R4R: Convenience ToDec() #3680

merged 7 commits into from
Feb 21, 2019

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Feb 19, 2019

closes #3456

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@rigelrozanski rigelrozanski changed the title WIP: Convenience ToDec() R4R: Convenience ToDec() Feb 19, 2019
PENDING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to fix CI:

x/distribution/keeper/delegation_test.go:173:48: undefined: sinitial
FAIL	github.com/cosmos/cosmos-sdk/x/distribution/keeper [build failed]

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #3680 into develop will increase coverage by <.01%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           develop   #3680      +/-   ##
==========================================
+ Coverage    61.19%   61.2%   +<.01%     
==========================================
  Files          190     190              
  Lines        13994   13995       +1     
==========================================
+ Hits          8563    8565       +2     
+ Misses        4895    4894       -1     
  Partials       536     536

@rigelrozanski
Copy link
Contributor Author

going to go ahead and merge with one approval as this is a highly cosmetic non-breaking change - I'd say almost classifies as a name change. slash me

@rigelrozanski rigelrozanski merged commit ab9de3a into develop Feb 21, 2019
@rigelrozanski rigelrozanski deleted the rigel/to-dec branch February 21, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToDec() function on sdk.Int
2 participants