Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored prefixes as constants #3676

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Refactored prefixes as constants #3676

merged 2 commits into from
Feb 18, 2019

Conversation

jleni
Copy link
Member

@jleni jleni commented Feb 18, 2019 •
edited
Loading

This PR closes #3675

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests (refactored, functionality did not change)

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jleni jleni requested a review from alexanderbez February 18, 2019 17:01
@jleni
Copy link
Member Author

jleni commented Feb 18, 2019

@alexanderbez Do you think we need an entry in pending here?

@alexanderbez
Copy link
Contributor

No @jleni, I don't think a pending log is needed 👍

@alexanderbez alexanderbez added WIP Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Feb 18, 2019
@jleni jleni marked this pull request as ready for review February 18, 2019 17:13
cwgoes
cwgoes approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes
Copy link
Contributor

cwgoes commented Feb 18, 2019

Ah @jleni looks like a test needs to be updated.

@cwgoes cwgoes merged commit 6967de1 into cosmos:develop Feb 18, 2019
@jleni jleni deleted the jleni/consts branch February 21, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor prefixes such as "acc", "pub", etc. into constants
4 participants
@jleni @alexanderbez @cwgoes @jackzampolin