Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: improve ledger docs #3649

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Conversation

gamarin2
Copy link
Contributor

Closes #3337

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #3649 into develop will increase coverage by 0.33%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3649      +/-   ##
===========================================
+ Coverage    60.92%   61.26%   +0.33%     
===========================================
  Files          188      186       -2     
  Lines        14084    13998      -86     
===========================================
- Hits          8581     8576       -5     
+ Misses        4959     4878      -81     
  Partials       544      544

@jackzampolin jackzampolin merged commit fb2d902 into develop Feb 14, 2019
@jackzampolin jackzampolin deleted the gamarin/improve-ledger-docs branch February 14, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants