R4R: BaseApp Peer Review #3526
Merged
R4R: BaseApp Peer Review #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossid
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
|
Should we open issues here? |
|
I think we should address them in this PR. |
Codecov Report
@@ Coverage Diff @@
## develop #3526 +/- ##
===========================================
+ Coverage 59.63% 59.64% +<.01%
===========================================
Files 131 131
Lines 9682 9691 +9
===========================================
+ Hits 5774 5780 +6
- Misses 3568 3571 +3
Partials 340 340 |
jackzampolin
reviewed
Feb 7, 2019
jackzampolin
reviewed
Feb 7, 2019
jackzampolin
reviewed
Feb 7, 2019
cwgoes
approved these changes
Feb 8, 2019
baseapp/baseapp.go
Outdated
| // NOTE: this changed in tendermint and we didn't notice... | ||
| return app.FilterPeerByPubKey(path[3]) | ||
| cmd, typ, arg := path[1], path[2], path[3] | ||
| if cmd == "filter" { |
jackzampolin
reviewed
Feb 8, 2019
| @@ -805,12 +804,13 @@ func (app *BaseApp) runTx(mode runTxMode, txBytes []byte, tx sdk.Tx) (result sdk | |||
| ctx = newCtx.WithMultiStore(ms) | |||
| } | |||
|
|
|||
| gasWanted = result.GasWanted | |||
There was a problem hiding this comment.
Reason for this change? Seems like this ordering might be significant...
jackzampolin
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @alexanderbez
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: