Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Show Mnemonic by Default #3524

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 6, 2019

Show the mnemonic by default.

closes: #3518


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good switch

@jleni
Copy link
Member

jleni commented Feb 6, 2019

It sounds weird and risky to me. The mnemonic is one of the most precious things.
If people want to see it, they have an option.. but showing it all the time?

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Feb 6, 2019

@jleni the thing is, this is what people are used to and want. As a user, I want to see my seed and write it down safely somewhere. If I'm in the presence of others, I'll manually supply the --no-backup flag (which I'd be doing for demo purposes only I imagine?).

The UX is counterintuitive to me w/o this change.

@jleni
Copy link
Member

jleni commented Feb 6, 2019

hehe. Some people are used to play with their mobiles while driving :-)

@jleni
Copy link
Member

jleni commented Feb 6, 2019

hopefully most people will use hardware wallets

@jackzampolin jackzampolin merged commit 17c84ab into develop Feb 6, 2019
@jackzampolin jackzampolin deleted the bez/3518-fix-keys-add-flow branch February 6, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI] Seed Phrase should be optionally visible
3 participants