R4R: Results from x/staking & x/slashing peer review #3507
Conversation
| @@ -385,7 +381,7 @@ func (k Keeper) UnbondAllMatureValidatorQueue(ctx sdk.Context) { | |||
| for _, valAddr := range timeslice { | |||
| val, found := k.GetValidator(ctx, valAddr) | |||
| if !found { | |||
| continue | |||
| panic("validator in the unbonding queue was not found") | |||
There was a problem hiding this comment.
As explained in person, not sure if this change makes sense
There was a problem hiding this comment.
RemoveValidator now removes the validator from the unbonding queue - thoughts?
There was a problem hiding this comment.
didn't we require this for determining unbonding-delegations or redelegations for slashing purposes? If that is not the case then this comment is resolved
There was a problem hiding this comment.
require what? the validator would still be around in that case, right?
cwgoes
changed the title
cwgoes
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #3507 +/- ##
==========================================
Coverage ? 57.27%
==========================================
Files ? 179
Lines ? 14104
Branches ? 0
==========================================
Hits ? 8078
Misses ? 5541
Partials ? 485 |
Co-Authored-By: cwgoes <cwgoes@pluranimity.org>
This isn't a |
Ahhh yes, indeed you're right. I'm indifferent where this should exist then. |
cc @jackzampolin
cc @rigelrozanski I expect you'll want to review this.
PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: