Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Add TxEncoder to client TxBuilder #2959

Merged
merged 5 commits into from
Dec 12, 2018
Merged

R4R: Add TxEncoder to client TxBuilder #2959

merged 5 commits into from
Dec 12, 2018

Conversation

arturalbov
Copy link
Contributor

@arturalbov arturalbov commented Nov 30, 2018 •
edited
Loading

closes #2926

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@arturalbov arturalbov requested a review from zramsay as a code owner December 3, 2018 11:20
@arturalbov arturalbov force-pushed the client_tx_encoder branch 2 times, most recently from 40ba22b to baf87b8 Compare December 3, 2018 12:57
@codecov
Copy link

codecov bot commented Dec 3, 2018 •
edited
Loading

Codecov Report

Merging #2959 into develop will increase coverage by 0.03%.
The diff coverage is 37.5%.

@@             Coverage Diff             @@
##           develop    #2959      +/-   ##
===========================================
+ Coverage    54.28%   54.32%   +0.03%     
===========================================
  Files          136      136              
  Lines        10212    10215       +3     
===========================================
+ Hits          5544     5549       +5     
+ Misses        4330     4328       -2     
  Partials       338      338

@arturalbov arturalbov changed the title WIP: Add TxEncoder to client TxBuilder R4R: Add TxEncoder to client TxBuilder Dec 3, 2018
@arturalbov
Copy link
Contributor Author

@ebuchman @cwgoes @fedekunze @zramsay Could you please review this PR?

@jackzampolin jackzampolin requested review from alexanderbez and sunnya97 and removed request for ebuchman, zramsay, rigelrozanski and cwgoes December 4, 2018 18:52
@hleb-albau
Copy link
Contributor

Any changes required here (beside rebase)?

@alexanderbez
Copy link
Contributor

Sorry, but I have not had the chance to review yet. Will do shortly.

@arturalbov arturalbov mentioned this pull request Dec 6, 2018
Closed
@jaekwon
Copy link
Contributor

jaekwon commented Dec 6, 2018

Will try to review tomorrow...

alexanderbez
alexanderbez suggested changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arturalbov! Looks great! Just a few minor comments 👍

client/utils/utils_test.go Show resolved Hide resolved
x/auth/client/txbuilder/txbuilder.go Outdated Show resolved Hide resolved
alexanderbez
alexanderbez approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look inline with what was suggested. Thanks @arturalbov!

alessio
alessio approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

alessio
alessio approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@alexanderbez alexanderbez requested a review from cwgoes December 6, 2018 16:49
@arturalbov
Copy link
Contributor Author

Thanks for review! Could you merge it?

@alexanderbez
Copy link
Contributor

I don't have merge permissions @arturalbov. Maybe @cwgoes can take a look and merge.

@cwgoes
Copy link
Contributor

cwgoes commented Dec 12, 2018

@arturalbov Sorry for the delay - I'll gladly review and merge this - can you quickly resolve the merge conflicts? Want to make sure I don't overwrite your changes.

@arturalbov
Copy link
Contributor Author

@cwgoes Done 👍

cwgoes
cwgoes approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit 0c6d53d into cosmos:develop Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@cwgoes cwgoes cwgoes approved these changes

@sunnya97 sunnya97 Awaiting requested review from sunnya97

@jaekwon jaekwon Awaiting requested review from jaekwon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TxEncoder to client TxBuilder
6 participants
@arturalbov @hleb-albau @alexanderbez @jaekwon @cwgoes @alessio