Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Address gov cli ux issues and add additional input validation for better errors #2938

Merged
merged 12 commits into from
Dec 3, 2018
Merged

R4R: Address gov cli ux issues and add additional input validation for better errors #2938

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9e61f37
Fix governance cli ux issues and add additional transaction validation
jackzampolin Nov 29, 2018
429d184
Remove last usage of proposal-id flag
jackzampolin Nov 29, 2018
bf950de
Add additional help text and begin to fix tests
jackzampolin Nov 29, 2018
67ea707
Fix broken test
jackzampolin Nov 29, 2018
5306b14
Update x/gov/client/cli/query.go
cwgoes Nov 29, 2018
77776c0
Update x/gov/client/cli/tx.go
cwgoes Nov 29, 2018
c9abcc5
Update x/gov/client/cli/query.go
cwgoes Nov 29, 2018
a298eb8
Update x/gov/client/cli/query.go
cwgoes Nov 29, 2018
28c7d85
Update docs and add PENDING entry
jackzampolin Dec 3, 2018
3f5b37e
Merge branch 'develop' into jack/gov-cli-fixes
jackzampolin Dec 3, 2018
266380c
Update docs/gaia/gaiacli.md
fedekunze Dec 3, 2018
8c3c454
Update docs/gaia/gaiacli.md
fedekunze Dec 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove last usage of proposal-id flag
  • Loading branch information
@jackzampolin
jackzampolin committed Nov 29, 2018
commit 429d184d14586ee361d7d8f7d0a961e0ba22a520
2 changes: 0 additions & 2 deletions x/gov/client/cli/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ func GetCmdQueryProposal(queryRoute string, cdc *codec.Codec) *cobra.Command {
},
}

cmd.Flags().String(flagProposalID, "", "proposalID of proposal being queried")

return cmd
}

Expand Down
1 change: 0 additions & 1 deletion x/gov/client/cli/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import (
)

const (
flagProposalID = "proposal-id"
flagTitle = "title"
flagDescription = "description"
flagProposalType = "type"
Expand Down