Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Update single node network bootstrapping documentation #2931

Merged
merged 3 commits into from
Nov 29, 2018

Conversation

jackzampolin
Copy link
Member

Title

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed. Left a few remarks. I also think we should word wrap the contents at 80 chars.

@@ -1,9 +1,53 @@
# Networks

There are a variety of ways to setup either local or remote networks with automation, detailed below.
All the required files are found in the [networks directory](https://github.com/cosmos/cosmos-sdk/tree/develop/networks) and additionally the `local` or `remote` sub-directories.
This document describes 3 ways to setup a network of `gaiad` nodes, each with an increasing level of complexity:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each with an increasing level of complexity: I'm not sure we need this? Maybe we can just say "serving various purposes or setups"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call.

docs/gaia/networks.md Show resolved Hide resolved
docs/gaia/networks.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #2931 into develop will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2931      +/-   ##
===========================================
+ Coverage     56.3%   56.35%   +0.05%     
===========================================
  Files          120      120              
  Lines         8417     8420       +3     
===========================================
+ Hits          4739     4745       +6     
+ Misses        3356     3353       -3     
  Partials       322      322

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@jackzampolin jackzampolin merged commit ddab04e into develop Nov 29, 2018
@jackzampolin jackzampolin deleted the jack/docs-fix branch November 29, 2018 20:39
mircea-c pushed a commit that referenced this pull request Dec 4, 2018
* Update single node network bootstrapping documentation to reflect changes to gentx
* Update docs/gaia/networks.md
* Address PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants