-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Update single node network bootstrapping documentation #2931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and reviewed. Left a few remarks. I also think we should word wrap the contents at 80 chars.
docs/gaia/networks.md
Outdated
@@ -1,9 +1,53 @@ | |||
# Networks | |||
|
|||
There are a variety of ways to setup either local or remote networks with automation, detailed below. | |||
All the required files are found in the [networks directory](https://github.com/cosmos/cosmos-sdk/tree/develop/networks) and additionally the `local` or `remote` sub-directories. | |||
This document describes 3 ways to setup a network of `gaiad` nodes, each with an increasing level of complexity: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
each with an increasing level of complexity:
I'm not sure we need this? Maybe we can just say "serving various purposes or setups"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call.
Codecov Report
@@ Coverage Diff @@
## develop #2931 +/- ##
===========================================
+ Coverage 56.3% 56.35% +0.05%
===========================================
Files 120 120
Lines 8417 8420 +3
===========================================
+ Hits 4739 4745 +6
+ Misses 3356 3353 -3
Partials 322 322 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
Co-Authored-By: jackzampolin <jack.zampolin@gmail.com>
c071de0
to
73bf002
Compare
* Update single node network bootstrapping documentation to reflect changes to gentx * Update docs/gaia/networks.md * Address PR comments
Title