Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flags in docs #2626

Merged
merged 1 commit into from
Oct 29, 2018
Merged

fix flags in docs #2626

merged 1 commit into from
Oct 29, 2018

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Oct 29, 2018

closes #2530

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@zramsay zramsay mentioned this pull request Oct 29, 2018
4 tasks
@alessio alessio self-requested a review October 29, 2018 17:52
@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #2626 into develop will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2626      +/-   ##
===========================================
- Coverage    58.85%   58.81%   -0.05%     
===========================================
  Files          152      152              
  Lines         9420     9420              
===========================================
- Hits          5544     5540       -4     
- Misses        3506     3510       +4     
  Partials       370      370

@rigelrozanski rigelrozanski merged commit 142cf74 into develop Oct 29, 2018
@rigelrozanski rigelrozanski deleted the zach/fixes branch October 29, 2018 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--address-validator unknown flag
3 participants