feat(iavlx): membership and nonmembership proofs #25579
Conversation
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:Keys
|
@technicallyty your pull request is missing a changelog! |
github-actions
bot
removed
C:x/staking
C:CLI
C:x/gov
C:Keys
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return nil, err | ||
| } | ||
| if rightNode != nil { | ||
| rightKey, err := rightNode.Key() |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
The best way to fix this problem is to handle the potential error from rightNode.Key() similarly to how it is handled for leftNode.Key(). That is, after calling rightKey, err := rightNode.Key(), check if err != nil and return early if it's not nil. This ensures that any unexpected error is handled gracefully and won't be missed.
Specifically, update the code at line 137 by assigning both rightKey and err, then immediately test err before progressing. You do not need to change any function signatures or imports. Only this code block inside GetNonMembershipProof is changed.
| @@ -135,7 +135,9 @@ | ||
| } | ||
| if rightNode != nil { | ||
| rightKey, err := rightNode.Key() | ||
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if rightKey != nil { | ||
| nonexist.Right, err = createExistenceProof(root, rightKey) | ||
| if err != nil { |
Description
Closes: #25573
Implements membership and non-membership proofs on IAVLX tree