-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix: prevent updating check state before mempool insert #25550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25550 +/- ##
==========================================
+ Coverage 69.95% 70.30% +0.35%
==========================================
Files 826 821 -5
Lines 54222 53789 -433
==========================================
- Hits 37929 37819 -110
+ Misses 16293 15970 -323
🚀 New features to boost your workflow:
|
|
@beer-1 lint failing |
|
@aljo242 fixed! |
|
@beer-1 do you see any potential for performance overhead due to this? |
I don't think this introduce any performance degradation because it is just changing order of execution |
Description
Closes: #25543