Skip to content

Conversation

@beer-1
Copy link
Contributor

@beer-1 beer-1 commented Nov 11, 2025

Description

Closes: #25543

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.30%. Comparing base (652f879) to head (09b7f4a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #25550      +/-   ##
==========================================
+ Coverage   69.95%   70.30%   +0.35%     
==========================================
  Files         826      821       -5     
  Lines       54222    53789     -433     
==========================================
- Hits        37929    37819     -110     
+ Misses      16293    15970     -323     
Files with missing lines Coverage Δ
baseapp/baseapp.go 84.29% <100.00%> (+0.54%) ⬆️

... and 8 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aljo242
Copy link
Contributor

aljo242 commented Nov 13, 2025

@beer-1 lint failing

@beer-1
Copy link
Contributor Author

beer-1 commented Nov 13, 2025

@aljo242 fixed!

@aljo242
Copy link
Contributor

aljo242 commented Nov 14, 2025

@beer-1 do you see any potential for performance overhead due to this?

@beer-1
Copy link
Contributor Author

beer-1 commented Nov 14, 2025

@beer-1 do you see any potential for performance overhead due to this?

I don't think this introduce any performance degradation because it is just changing order of execution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: prevent invalid sequence rejections caused by early ante state writes

2 participants