Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: linting fixes #23136

Merged
merged 5 commits into from
Dec 31, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
linting fixes
  • Loading branch information
tac0turtle committed Dec 31, 2024
commit c398a85105a3ef58a96cfc89d42efe657376367e
2 changes: 1 addition & 1 deletion depinject/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cosmossdk.io/depinject

go 1.21
go 1.22

require (
github.com/cosmos/cosmos-proto v1.0.0-beta.5
Expand Down
2 changes: 1 addition & 1 deletion errors/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ module cosmossdk.io/errors/v2

// NOTE: this go.mod should have zero dependencies.

go 1.20
go 1.22
3 changes: 0 additions & 3 deletions log/bench_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ func BenchmarkLoggers(b *testing.B) {
// so that real write time is negligible.
b.Run("zerolog", func(b *testing.B) {
for _, bc := range benchCases {
bc := bc
b.Run(bc.name, func(b *testing.B) {
zl := zerolog.New(io.Discard)
logger := log.NewCustomLogger(zl)
Expand All @@ -99,7 +98,6 @@ func BenchmarkLoggers(b *testing.B) {
// also useful as a reference for how expensive zerolog is.
b.Run("specialized nop logger", func(b *testing.B) {
for _, bc := range nopCases {
bc := bc
b.Run(bc.name, func(b *testing.B) {
logger := log.NewNopLogger()

Expand All @@ -115,7 +113,6 @@ func BenchmarkLoggers(b *testing.B) {
// so we offer the specialized version in the exported API.
b.Run("zerolog nop logger", func(b *testing.B) {
for _, bc := range nopCases {
bc := bc
b.Run(bc.name, func(b *testing.B) {
logger := log.NewCustomLogger(zerolog.Nop())

Expand Down
2 changes: 1 addition & 1 deletion log/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cosmossdk.io/log

go 1.21
go 1.22

require (
github.com/bytedance/sonic v1.12.6
Expand Down
2 changes: 1 addition & 1 deletion math/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cosmossdk.io/math

go 1.20
go 1.22

require (
github.com/cockroachdb/apd/v3 v3.2.1
Expand Down
1 change: 0 additions & 1 deletion math/legacy_dec_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,6 @@ func TestFormatDecNonDigits(t *testing.T) {
}

for _, value := range badCases {
value := value
t.Run(value, func(t *testing.T) {
s, err := math.FormatDec(value)
if err == nil {
Expand Down
9 changes: 5 additions & 4 deletions tests/integration/v2/example/example_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@ import (

// Example shows how to use the integration test framework to test the integration of SDK modules.
// Panics are used in this example, but in a real test case, you should use the testing.T object and assertions.
func Example(t *testing.T) {
func Example() {
// example functions should not take any arguments, t is created in the function to avoid passing it
// in your code pass t to the integration test function
t := &testing.T{}
authority := authtypes.NewModuleAddress("gov").String()

var (
mintKeeper *mintkeeper.Keeper
)
var mintKeeper *mintkeeper.Keeper

moduleConfigs := []configurator.ModuleOption{
configurator.AccountsModule(),
Expand Down
Loading