Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug [WIP] (x/accounts/defaults/lockup): Accounting slashing in delegation locking amount #22288

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sontrinh16
Copy link
Member

Description

A WIP, try to store delegation share in delegationLocking and delegationFree instead of total delegation amount so when validator get slashed the trackDelegation and trackUndelegation can still have accurate delegateLocking, delegateFree amount

cons, have to iterate over all of lockup account delegation entries + query validator for each entry to calculate total token from all the shares


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

delLockingAmt, err := bva.DelegatedLocking.Get(ctx, bondDenom)
var delLockingAmt math.Int
delLockingShare := math.LegacyZeroDec()
delFreeShare := math.LegacyZeroDec()

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This definition of delFreeShare is never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant